Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exit with 1 if WPT runner has unexpected errors #2621

Merged
merged 5 commits into from
Jan 16, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/wpt/runner/runner.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ export class WPTRunner extends EventEmitter {
`skipped: ${skipped}`
)

process.exit(0)
process.exit(failed - expectedFailures ? 1 : 0)
KhafraDev marked this conversation as resolved.
Show resolved Hide resolved
}

addInitScript (code) {
Expand Down
6 changes: 6 additions & 0 deletions test/wpt/runner/worker.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { WebSocket } from '../../../lib/websocket/websocket.js'
import { Cache } from '../../../lib/cache/cache.js'
import { CacheStorage } from '../../../lib/cache/cachestorage.js'
import { kConstruct } from '../../../lib/cache/symbols.js'
import { webcrypto } from 'node:crypto'

const { initScripts, meta, test, url, path } = workerData

Expand Down Expand Up @@ -89,6 +90,11 @@ Object.defineProperties(globalThis, {
CacheStorage: {
...globalPropertyDescriptors,
value: CacheStorage
},
// TODO: remove once node 18 is dropped
crypto: {
...globalPropertyDescriptors,
value: webcrypto
KhafraDev marked this conversation as resolved.
Show resolved Hide resolved
}
})

Expand Down
6 changes: 6 additions & 0 deletions test/wpt/status/fetch.status.json
Original file line number Diff line number Diff line change
Expand Up @@ -417,6 +417,12 @@
"note": "this is a bug in webstreams, see https://github.com/nodejs/node/issues/46786",
"skip": true
}
},
"idlharness.any.js": {
"note": "https://github.com/nodejs/undici/issues/1666#issuecomment-1275177704",
"fail": [
"Window interface: operation fetch(RequestInfo, optional RequestInit)"
]
}
},
"content-length": {
Expand Down
Loading