Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run compare on perf cores #162

Merged
merged 2 commits into from
Apr 10, 2024
Merged

run compare on perf cores #162

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
670d8e3
run compare on perf cores
rluvaton Apr 10, 2024
1edf22d
update http to https
rluvaton Apr 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions benchmarks/community-benchmark/run.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ getMACHINE_THREADS=`cat /proc/cpuinfo |grep processor|tail -n1|awk {'print $3'}`
let getMACHINE_THREADS=getMACHINE_THREADS+1 #getting threads this way is 0 based. Add one
optional MACHINE_THREADS $getMACHINE_THREADS
rm -rf node
git clone http://github.com/nodejs/node.git
git clone https://github.com/nodejs/node.git
cd node
case $USE_CASE in
1)
Expand Down Expand Up @@ -100,7 +100,9 @@ fi
fileName=output`date +%d%m%y-%H%M%S`.csv
echo "Output will be saved to $fileName"
pwd
./node-master benchmark/compare.js --old ./node-master --new ./node-pr $FILTER $RUNS -- $CATEGORY | tee $fileName

# Run on performance cores
taskset -c 0-11 ./node-master benchmark/compare.js --old ./node-master --new ./node-pr $FILTER $RUNS -- $CATEGORY | tee $fileName
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would fail on non-linux environments I assume? Can we make it work with Windows and macOS as well?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as @richardlau is not runnable outside the build infra


cat $fileName | Rscript benchmark/compare.R
mv $fileName $startDir