Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed 10E7 to numeric for better readability #6990

Merged
merged 1 commit into from
Aug 18, 2024
Merged

Conversation

sachin-vs
Copy link
Contributor

@sachin-vs sachin-vs commented Aug 16, 2024

Description

Under the chapter "Asynchronous Flow Control," in the "Limited Parallel" section, the text originally states:

"Limited parallel: parallel with limit, such as successfully emailing 1,000,000 recipients from a list of 10E7 users."

However, 10E7 means 100 million, while the code example uses a function titled getListOfTenMillionGreatEmails. To improve readability and ensure consistency with the code, I changed the sentence to:

"Limited parallel: parallel with limit, such as successfully emailing 1,000,000 recipients from a list of 10 million users."

Validation

nodejs

Related Issues

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

@sachin-vs sachin-vs requested a review from a team as a code owner August 16, 2024 08:56
Copy link

vercel bot commented Aug 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Aug 16, 2024 8:58am

Copy link
Member

@mikeesto mikeesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

Copy link
Contributor

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!! Thanks

Copy link

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.67% (593/654) 76.08% (175/230) 94.57% (122/129)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 5.476s ⏱️

@mikeesto mikeesto added this pull request to the merge queue Aug 18, 2024
Merged via the queue into nodejs:main with commit 1addb08 Aug 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants