Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(layout): Refractoring #6929

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat(layout): Refractoring #6929

wants to merge 3 commits into from

Conversation

AugustinMauroy
Copy link
Contributor

@AugustinMauroy AugustinMauroy commented Jul 17, 2024

Description

  • Remove handwritten ToC, and use metabar
  • Clean and merge some layout to simplify our logic.

Related Issues

It's one solution for #6922

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npm run format to ensure the code follows the style guide.
  • I have run npm run test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.

Copy link

vercel bot commented Jul 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ❌ Failed (Inspect) Sep 24, 2024 9:45am

@ovflowd
Copy link
Member

ovflowd commented Jul 20, 2024

Is this still a draft?

@AugustinMauroy
Copy link
Contributor Author

Is this still a draft?

Yes and no. Basically, the component and file names are clearly not the right ones. But I have no idea.
But from a code point of view nothing will change in my opinion

@AugustinMauroy AugustinMauroy marked this pull request as ready for review August 15, 2024 08:43
@AugustinMauroy AugustinMauroy requested a review from a team as a code owner August 15, 2024 08:43
@bmuenzenmeyer
Copy link
Collaborator

Is the only thing blocking this the naming?

@AugustinMauroy
Copy link
Contributor Author

Yeah 😅 I'm not fan about how layout is named

@mikeesto
Copy link
Member

ArticlePageLayout?

@bmuenzenmeyer
Copy link
Collaborator

I'm working on this addition to the COLLABORATOR_GUIDE. I was hoping it would help us identify the SimplePage uniqueness, and perhaps simplify our layouts - we have a LOT

Layouts

There are several Layouts available within the Website. Here's a comparison of their features:

Layout Includes Layout... WithNavBar WithSidebar WithFooter WithMetaBar WithBreadcrumbs Comment / Custom Element(s)
Default Article
About Article
SimplePage Article
Learn Article WithSidebarCrossLinks
Post Content WithBlogCrossLinks
Blog WithBlogCategories
Download WithDownloadCategories
Search
Centered
Base NotificationProvider and NavigationStateProvider
Home Centered GlowingBackdrop
Article CSS Only
Content CSS Only

@AugustinMauroy
Copy link
Contributor Author

AugustinMauroy commented Sep 10, 2024

Centered and home can be merge; and content with post ?

@ovflowd
Copy link
Member

ovflowd commented Sep 11, 2024

Centered and home can be merge; and content with post ?

If it works, it works. Do it.

@AugustinMauroy AugustinMauroy changed the title feat(layout): introduce SimplePage feat(layout): Refractoring Sep 12, 2024
@ovflowd

This comment was marked as outdated.

Copy link

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
90.47% (589/651) 76.29% (177/232) 94.35% (117/124)

Unit Test Report

Tests Skipped Failures Errors Time
131 0 💤 0 ❌ 0 🔥 5.115s ⏱️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The table of contents does not work for translated pages for community package managers
5 participants