Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: zoom issue on smaller screens due to focus #6455

Merged
merged 2 commits into from
Mar 6, 2024

Conversation

manishprivet
Copy link
Member

Description

Clicking on the Navigation Panel on mobile zooms the website because of it having an input component in focus. This is unwanted behaviour. We can use the maximumScale property on meta viewport to prevent this.

Validation

Ref: https://developer.mozilla.org/en-US/docs/Web/HTML/Viewport_meta_tag#maximum-scale

Related Issues

Fixes: #6416

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I have run npx turbo build to check if the website builds without errors.
  • I've covered new added functionality with unit tests if necessary.

Signed-off-by: Manish Kumar ⛄ <manishprivet@protonmail.com>
…eens

fix: zoom issue on smaller screens due to focus
@manishprivet manishprivet requested a review from a team as a code owner March 6, 2024 06:18
Copy link

vercel bot commented Mar 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Mar 6, 2024 6:20am

Copy link
Contributor

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@AugustinMauroy AugustinMauroy added website redesign Issue/PR part of the Node.js Website Redesign github_actions:pull-request Trigger Pull Request Checks labels Mar 6, 2024
Copy link

github-actions bot commented Mar 6, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 96 🟢 90 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 91 🟢 100 🟢 92 🔗
/en/about/previous-releases 🟢 100 🟢 90 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟠 89 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 90 🟢 100 🟢 92 🔗

Copy link

github-actions bot commented Mar 6, 2024

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 85%
80.18% (433/540) 79.65% (137/172) 73.07% (76/104)

Unit Test Report

Tests Skipped Failures Errors Time
88 0 💤 0 ❌ 0 🔥 4.503s ⏱️

@ovflowd ovflowd added this pull request to the merge queue Mar 6, 2024
@ovflowd ovflowd added the fast-track Fast Tracking PRs label Mar 6, 2024
Merged via the queue into nodejs:main with commit a8efa11 Mar 6, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track Fast Tracking PRs website redesign Issue/PR part of the Node.js Website Redesign
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Navigation Panel Issue
3 participants