feat: enable sentry features #6133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
removed
the
github_actions:pull-request
|
Lighthouse Results
|
Unit Test Coverage Report
Unit Test Report
|
github-actions
bot
removed
the
github_actions:pull-request
AbhiPrasad
reviewed
Nov 21, 2023
ovflowd
force-pushed
the
feat/enable-tree-shaking-and-specific-features
branch
from
7c2e3dc
to
89b0e51
Compare
github-actions
bot
removed
the
github_actions:pull-request
github-actions
bot
removed
the
github_actions:pull-request
|
@AbhiPrasad I've noticed by using the Sentry Client the way we are (with BrowserClient) the client-side requests are not going through
Is there something else we need to configure? |
github-actions
bot
removed
the
github_actions:pull-request
I was able to make a fix, by 👀 Sentry's source code. |
github-actions
bot
removed
the
github_actions:pull-request
|
cc @nodejs/web-infra for reviewes :) |
bmuenzenmeyer
approved these changes
Nov 23, 2023
github-actions
bot
removed
the
github_actions:pull-request
github-actions
bot
removed
the
github_actions:pull-request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR attempts to tree-shake irrelevant Sentry parts and load a minimal Sentry Browser Client for our Next.js installation.
This PR should also disable support of UnhandledPromise rejection from Sentry
Notice that two unrelated changes in this PR are two tiny hot fixes (1 removing a console).timeEnd, 2 fixing a bug that if no static data is generated HomeDownloadButton crashes due to node release data being empty)
Validation
I've seen no bundle increase with this setup, which is intriguing. The expected outcome here is for all Sentry features to be working correctly.
cc @AbhiPrasad @JonasBa for review from Sentry side
cc @bmuenzenmeyer for internal review