Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: update next.js and remove robots.txt gen #5812

Merged
merged 7 commits into from
Sep 21, 2023
Merged

meta: update next.js and remove robots.txt gen #5812

merged 7 commits into from
Sep 21, 2023

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Sep 19, 2023

This PR updates Next.js to v13.5.1 and removes the Sitemap CLI generation in favor of a static robots.txt file (as it never changes)

@vercel
Copy link

vercel bot commented Sep 19, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 20, 2023 7:38pm

@ovflowd ovflowd changed the title Meta/update next remove robots gen meta: update next.js and remove robots.txt gen Sep 19, 2023
@ovflowd ovflowd added the infrastructure Issues/PRs related to the Repository Infra label Sep 19, 2023
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Sep 19, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Sep 19, 2023
@ovflowd
Copy link
Member Author

ovflowd commented Sep 19, 2023

Blocked by storybookjs/storybook#24234

AugustinMauroy
AugustinMauroy reviewed Sep 19, 2023
View reviewed changes
public/robots.txt Outdated Show resolved Hide resolved
AugustinMauroy
AugustinMauroy reviewed Sep 19, 2023
View reviewed changes
app/robots.ts Outdated Show resolved Hide resolved
bmuenzenmeyer
bmuenzenmeyer requested changes Sep 19, 2023
View reviewed changes
Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one typo

this still looks really odd to me that in a PR where we are excited about new next functionality, our package.json is set to 13.4.19

app/robots.ts Outdated Show resolved Hide resolved
@bmuenzenmeyer
Update app/robots.ts
dfe6daf 
Signed-off-by: Brian Muenzenmeyer <brian.muenzenmeyer@gmail.com>
@ovflowd
Copy link
Member Author

ovflowd commented Sep 20, 2023

this still looks really odd to me that in a PR where we are excited about new next functionality, our package.json is set to 13.4.19

Why is this a typo? The package-lock is what matters.

@bmuenzenmeyer bmuenzenmeyer mentioned this pull request Sep 20, 2023
Closed
@ovflowd ovflowd added the github_actions:pull-request Trigger Pull Request Checks label Sep 20, 2023
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Sep 20, 2023
@ovflowd
Copy link
Member Author

ovflowd commented Sep 20, 2023

@bmuenzenmeyer could you re-review this?

@github-actions
Copy link

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 92%
 90.24% (185/205) 75% (30/40) 86.66% (39/45)

Unit Test Report

Tests Skipped Failures Errors Time
14 0 💤 0 ❌ 0 🔥 4.991s ⏱️

bmuenzenmeyer
bmuenzenmeyer approved these changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@bmuenzenmeyer bmuenzenmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ test
✅ lint
✅ build
✅ deploy
✅ serve

@AugustinMauroy AugustinMauroy mentioned this pull request Sep 21, 2023
Merged
4 tasks
@ovflowd ovflowd added the fast-track Fast Tracking PRs label Sep 21, 2023
@ovflowd
Copy link
Member Author

ovflowd commented Sep 21, 2023

I'm fast-tracking this PR to unblock related work.

@ovflowd ovflowd merged commit ff81f93 into main Sep 21, 2023
17 of 19 checks passed
@ovflowd ovflowd deleted the meta/update-next-remove-robots-gen branch September 21, 2023 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AugustinMauroy AugustinMauroy AugustinMauroy left review comments

@bmuenzenmeyer bmuenzenmeyer bmuenzenmeyer approved these changes

Assignees
No one assigned
Labels
fast-track Fast Tracking PRs infrastructure Issues/PRs related to the Repository Infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ovflowd @bmuenzenmeyer @AugustinMauroy