Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: symmetric git diff due to head behind base #5590

Merged
merged 2 commits into from
Jul 31, 2023

Conversation

ovflowd
Copy link
Member

@ovflowd ovflowd commented Jul 31, 2023

Description

This is a hot-fix for "git diff" giving symmetric commits as the base.sha refers to a commit that is not fetched (checked out) during our shallow clone. Hence we update the --filter command to use the relative comparison of HEAD~N...HEAD where N amount of commits of the current Pull Request.

@ovflowd ovflowd requested a review from a team as a code owner July 31, 2023 21:04
@vercel
Copy link

vercel bot commented Jul 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2023 9:05pm
nodejs-org-stories ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 31, 2023 9:05pm

@ovflowd ovflowd added the fast-track Fast Tracking PRs label Jul 31, 2023
@vercel vercel bot temporarily deployed to Preview – nodejs-org July 31, 2023 21:04 Inactive
@vercel vercel bot temporarily deployed to Preview – nodejs-org-stories July 31, 2023 21:05 Inactive
@github-actions
Copy link

📦 Next.js Bundle Analysis for nodejs.org

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions
Copy link

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 93%
92.42% (366/396) 79% (79/100) 88.09% (74/84)

Unit Test Report

Tests Skipped Failures Errors Time
45 0 💤 0 ❌ 0 🔥 10.509s ⏱️

@ovflowd ovflowd merged commit a1b59da into main Jul 31, 2023
11 checks passed
@ovflowd ovflowd deleted the chore/fix-symetric-git-diff branch July 31, 2023 21:10
@ovflowd
Copy link
Member Author

ovflowd commented Jul 31, 2023

Merging as a hot-fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track Fast Tracking PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant