Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

icon: need update LinkedIn #6928

Closed
AugustinMauroy opened this issue Jul 17, 2024 · 2 comments · Fixed by #6932
Closed

icon: need update LinkedIn #6928

AugustinMauroy opened this issue Jul 17, 2024 · 2 comments · Fixed by #6932
Labels

Comments

@AugustinMauroy
Copy link
Contributor

AugustinMauroy commented Jul 17, 2024

Issue:

We are violating LinkedIn Trademark ! Here the LinkedIn trademark policy

Solution:

Update the component components/Icons/Social/LinkedIn.tsx

Here svg extract from LinkedIn website:
(yeah they didn't furnish svg)

<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 24 24" fill="currentColor" class="mercado-match" width="24" height="24" focusable="false">
      <path d="M20.5 2h-17A1.5 1.5 0 002 3.5v17A1.5 1.5 0 003.5 22h17a1.5 1.5 0 001.5-1.5v-17A1.5 1.5 0 0020.5 2zM8 19H5v-9h3zM6.5 8.25A1.75 1.75 0 118.3 6.5a1.78 1.78 0 01-1.8 1.75zM19 19h-3v-4.74c0-1.42-.6-1.93-1.38-1.93A1.74 1.74 0 0013 14.19a.66.66 0 000 .14V19h-3v-9h2.9v1.3a3.11 3.11 0 012.7-1.4c1.55 0 3.36.86 3.36 3.66z"></path>
</svg>
Jay-Karia added a commit to Jay-Karia/nodejs.org that referenced this issue Jul 17, 2024
Signed-off-by: Jay <jay.sanjay.karia@gmail.com>
@ostrich-egg
Copy link

ostrich-egg commented Jul 18, 2024

Hi, can you help me to understand this attribute class="mercado-match", should it be class or className? and does class="mercado-match" exists? because there were no class used in other svg like in Twitter.tsx.

@Jay-Karia Jay-Karia mentioned this issue Jul 18, 2024
5 tasks
@ovflowd
Copy link
Member

ovflowd commented Jul 20, 2024

Hi, can you help me to understand this attribute class="mercado-match", should it be class or className? and does class="mercado-match" exists? because there were no class used in other svg like in Twitter.tsx.

class is a reserved word in React; The HTML counterpart for class in React is className

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants