Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: added validation regex argument to test #9918

Closed

Conversation

knarfishness
Copy link

@knarfishness knarfishness commented Dec 1, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

In this change, I've added the regex pattern to the assert.throws()
in order to provide the validation argument for the call.

In this change, I've added the regex pattern to the assert.throws()
in order to provide the validation argument for the call.
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
@knarfishness
Copy link
Author

This was made at the NINA Code and Learn session.

@mscdex mscdex added the fs Issues and PRs related to the fs subsystem / file system. label Dec 1, 2016
@imyller imyller added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 1, 2016
@@ -46,7 +46,7 @@ file
assert.throws(function() {
console.error('write after end should not be allowed');
file.write('should not work anymore');
});
}, /write/);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can a more substantial match be used here?

@Trott
Copy link
Member

Trott commented Dec 12, 2016

Ping @knarfishness: Can you address @cjihrig's comment? It would be great if the match could be more than one word. Probably this would be best: /^Error: write after end$/

@Trott
Copy link
Member

Trott commented Dec 22, 2016

Ping @cjihrig: It appears that this has been updated to address your comment. Can you please take a look and, as appropriate update your review?

@italoacasas
Copy link
Contributor

Trott pushed a commit to Trott/io.js that referenced this pull request Dec 23, 2016
In this change, I've added the regex pattern to the assert.throws()
in order to provide the validation argument for the call.

PR-URL: nodejs#9918
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott
Copy link
Member

Trott commented Dec 23, 2016

Landed in 4e1b2e7.
Thanks for the contribution! 🎉

@Trott Trott closed this Dec 23, 2016
targos pushed a commit that referenced this pull request Dec 26, 2016
In this change, I've added the regex pattern to the assert.throws()
in order to provide the validation argument for the call.

PR-URL: #9918
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Dec 26, 2016
In this change, I've added the regex pattern to the assert.throws()
in order to provide the validation argument for the call.

PR-URL: #9918
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Dec 27, 2016
evanlucas pushed a commit that referenced this pull request Jan 3, 2017
In this change, I've added the regex pattern to the assert.throws()
in order to provide the validation argument for the call.

PR-URL: #9918
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
evanlucas pushed a commit that referenced this pull request Jan 4, 2017
In this change, I've added the regex pattern to the assert.throws()
in order to provide the validation argument for the call.

PR-URL: #9918
Reviewed-By: Teddy Katz <teddy.katz@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. fs Issues and PRs related to the fs subsystem / file system. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants