test: refactor make-callback-recurse test #9498
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move copy/pasted callback into its own function.
Trott
added
timers
mscdex
reviewed
Nov 7, 2016
| }); | ||
| throw new Error('UNREACHABLE'); | ||
| })); | ||
| process.nextTick(common.mustCall(testTimer.bind(null, 3))); |
There was a problem hiding this comment.
All 3 of these functions allow passing arguments to the callback, why not take advantage of that instead of binding?
There was a problem hiding this comment.
Because it's late and I'm tired and not thinking as clearly as I should be.
Oh, wait, it's 8:41 PM. Can't use that excuse.
Anyway, yes, changed! Thanks.
cjihrig
approved these changes
Nov 7, 2016
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Nov 10, 2016
Move copy/pasted callback into its own function. PR-URL: nodejs#9498 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
|
Landed in 837e822 |
addaleax
pushed a commit
that referenced
this pull request
Nov 22, 2016
Move copy/pasted callback into its own function. PR-URL: #9498 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
Move copy/pasted callback into its own function. PR-URL: nodejs#9498 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
Move copy/pasted callback into its own function. PR-URL: #9498 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test timers addons
Description of change
Move copy/pasted callback into its own function.