V6.9.1 proposal #9186

MylesBorins · 2016-10-19T13:17:45Z

2016-10-19, Version 6.9.1 'Boron' (LTS), @thealphanerd

Notable changes

streams: Fix a regression in readable stream that caused unpipe to remove the wrong stream (Anna Henningsen)

Commits

[2c3bbb576c] - doc: fix changelog index for v6.9.0 (Rod Vagg) #9168
[f4b766f5b7] - streams: fix regression in unpipe() (Anna Henningsen) #9171
[6072326009] - test: add regression test for unpipe() (Niels Nielsen) #9171
[9f248a4d83] - tools: check tag is on github before release (Rod Vagg) #9142
[c74d3a700a] - tools: make detached SHASUM .sig file for releases (Rod Vagg) #9071
[955bbf876f] - tools: explicitly set digest algo for SHASUM to 256 (Rod Vagg) #9071

PR-URL: #9168 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>

PR-URL: #9071 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

PR-URL: #9142 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Since 2e568d9 there is a bug where unpiping a stream from a readable stream that has `_readableState.pipesCount > 1` will cause it to remove the first stream in the `_.readableState.pipes` array no matter where in the list the `dest` stream was. This patch corrects that problem. PR-URL: #9171 Fixes: #9170 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

Since 2e568d9 there is a bug where unpiping a stream from a readable stream that has `_readableState.pipesCount > 1` will cause it to remove the first stream in the `_.readableState.pipes` array no matter where in the list the `dest` stream was. PR-URL: #9171 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

MylesBorins · 2016-10-19T13:22:23Z

The only commits we absolutely need to include in this release are f4b766f and 6072326

I've included the other commits that were on v6.x-staging as they were all tooling related and likely to make the release process smoother.

ci: https://ci.nodejs.org/job/node-test-pull-request/4576/
citgm: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/427/

/cc @nodejs/ctc @nodejs/lts

evanlucas · 2016-10-19T13:34:37Z

doc/changelogs/CHANGELOG_V6.md

@@ -39,7 +40,23 @@
 [Node.js Long Term Support Plan](https://github.com/nodejs/LTS) and
 will be supported actively until April 2018 and maintained until April 2019.

-<a id="6.8.1"></a>
+<a id="6.9.0"></a>


This should be 6.9.1

Notable changes: * streams: Fix a regression in readable stream that caused unpipe to remove the wrong stream (Anna Henningsen) PR-URL: nodejs#9186

Fishrock123 · 2016-10-19T13:47:24Z

Do we want to do this this week?

It sounds like this was only an issue for a minority of users if it wasn't caught for v6.8.1 or v6.9.0...?

Personally I would probably just do a patch next week unless this is breaking a lot of users.

evanlucas · 2016-10-19T13:51:23Z

I'm +1 for a release this week. Especially since v6.x fixed a few security issues.

jasnell · 2016-10-19T15:32:19Z

As long as we can get this out today I'm +1. Thursday and Friday releases aren't the best.

MylesBorins · 2016-10-19T16:41:54Z

smart os and arm failures are infra related.

Local OSX is passing, so I think we can ignore those.

Going to rerun BSD one more time: https://ci.nodejs.org/job/node-test-commit-freebsd/4901/

Build: https://ci-release.nodejs.org/job/iojs+release/1273/

edit: citgm failures included a body-parser failure on osx and a core-dump with async on fedora 22.

I have tested locally to confirm that the body-parser failure is not repeatable, currently ssh'd into a fedora box and compiling to confirm that it cannot be reproduced there

edit:

Manually tested async on fedora, no issues. CITGM looks good

MylesBorins · 2016-10-19T17:07:11Z

Still a single failure on BSD
https://ci.nodejs.org/job/node-test-commit-freebsd/4901/nodes=freebsd11-x64/tapTestReport/test.tap-970/

@nodejs/platform-freebsd is this concerning to you?

jbergstroem · 2016-10-19T17:13:35Z

@thealphanerd I'm in no shape to have a look at it.

Fishrock123 · 2016-10-19T17:32:27Z

Based on the reports received, not sure this is not high enough priority to warrant another release this week.

mhdawson · 2016-10-19T20:26:41Z

Same as James: "As long as we can get this out today I'm +1. Thursday and Friday releases aren't the best."

Notable changes: * streams: Fix a regression introduced in v6.8.0 in readable stream that caused unpipe to remove the wrong stream (Anna Henningsen) PR-URL: #9186

PR-URL: #9186

Notable changes: * streams: Fix a regression introduced in v6.8.0 in readable stream that caused unpipe to remove the wrong stream (Anna Henningsen) PR-URL: #9186

addaleax · 2016-10-20T12:03:30Z

@Fishrock123 I’m curious – if there is something that’s clearly a regression with an easy fix and there’s a releaser willing to put together a release, what are generally the reasons not to do one?

rvagg and others added 6 commits October 19, 2016 14:06

tools: explicitly set digest algo for SHASUM to 256

955bbf8

PR-URL: #9071 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

tools: make detached SHASUM .sig file for releases

c74d3a7

PR-URL: #9071 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>

tools: check tag is on github before release

9f248a4

PR-URL: #9142 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

MylesBorins added meta Issues and PRs related to the general management of the project. lts Issues and PRs related to Long Term Support releases. v6.x labels Oct 19, 2016

MylesBorins force-pushed the v6.9.1-proposal branch from 914e7fb to ea5d2d9 Compare October 19, 2016 13:19

evanlucas reviewed Oct 19, 2016

View reviewed changes

MylesBorins force-pushed the v6.9.1-proposal branch from ea5d2d9 to 4cd8f62 Compare October 19, 2016 13:36

2016-10-19, Version 6.9.1 'Boron' (LTS) Release

6eebe68

Notable changes: * streams: Fix a regression introduced in v6.8.0 in readable stream that caused unpipe to remove the wrong stream (Anna Henningsen) PR-URL: #9186

MylesBorins force-pushed the v6.9.1-proposal branch from 4cd8f62 to 6eebe68 Compare October 19, 2016 21:38

MylesBorins merged commit 6eebe68 into v6.x Oct 19, 2016

MylesBorins pushed a commit that referenced this pull request Oct 19, 2016

Working on v6.9.2

8bb346d

PR-URL: #9186

MylesBorins pushed a commit that referenced this pull request Oct 19, 2016

2016-10-19, Version 6.9.1 'Boron' (LTS) Release

4b65a65

Notable changes: * streams: Fix a regression introduced in v6.8.0 in readable stream that caused unpipe to remove the wrong stream (Anna Henningsen) PR-URL: #9186

MylesBorins mentioned this pull request Oct 19, 2016

blog: release post for v6.9.1 nodejs/nodejs.org#986

Merged

MylesBorins deleted the v6.9.1-proposal branch December 15, 2016 18:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

V6.9.1 proposal #9186

V6.9.1 proposal #9186

MylesBorins commented Oct 19, 2016

MylesBorins commented Oct 19, 2016

evanlucas Oct 19, 2016

MylesBorins Oct 19, 2016

Fishrock123 commented Oct 19, 2016

evanlucas commented Oct 19, 2016

jasnell commented Oct 19, 2016

MylesBorins commented Oct 19, 2016 •

edited

Loading

MylesBorins commented Oct 19, 2016

jbergstroem commented Oct 19, 2016

Fishrock123 commented Oct 19, 2016

mhdawson commented Oct 19, 2016

addaleax commented Oct 20, 2016

V6.9.1 proposal #9186

V6.9.1 proposal #9186

Conversation

MylesBorins commented Oct 19, 2016

2016-10-19, Version 6.9.1 'Boron' (LTS), @thealphanerd

Notable changes

Commits

MylesBorins commented Oct 19, 2016

evanlucas Oct 19, 2016

Choose a reason for hiding this comment

MylesBorins Oct 19, 2016

Choose a reason for hiding this comment

Fishrock123 commented Oct 19, 2016

evanlucas commented Oct 19, 2016

jasnell commented Oct 19, 2016

MylesBorins commented Oct 19, 2016 • edited Loading

MylesBorins commented Oct 19, 2016

jbergstroem commented Oct 19, 2016

Fishrock123 commented Oct 19, 2016

mhdawson commented Oct 19, 2016

addaleax commented Oct 20, 2016

MylesBorins commented Oct 19, 2016 •

edited

Loading