Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readline: use icu based string width calculation #9040

Closed
wants to merge 1 commit into from
Closed

readline: use icu based string width calculation #9040

wants to merge 1 commit into from

Commits on Oct 25, 2016

  1. readline: use icu based string width calculation 

    Rather than the pseudo-wcwidth impl used currently, use the ICU
character properties database to calculate string width and
determine if a character is full width or not. This allows the
algorithm to correctly identify emoji's as full width, ensures
the algorithm will continue to fucntion properly as new unicode
codepoints are added, and it's faster.

This was originally part of a proposal to add a new unicode module,
but has been split out.

Refs: nodejs#8075
    @jasnell
    jasnell committed Oct 25, 2016
    Configuration menu
    Copy the full SHA
    876bb83 View commit details
    Browse the repository at this point in the history