inspector: add --inspect-brk flag #8979
Conversation
nodejs-github-bot
added
the
c++
|
If this gets merged, it should have tests. |
|
https://github.com/nodejs/node/blob/master/test/inspector/inspector-helper.js#L404 - I think this flag can be used here. |
joshgav
force-pushed
the
inspect-brk
branch
2 times, most recently
from
5f41374
to
24d5e39
Compare
| @@ -13,7 +13,7 @@ if (cluster.isMaster) { | |||
|
|
|||
| function fork(offset, execArgv) { | |||
| if (execArgv) | |||
| cluster.setupMaster({execArgv}); | |||
| cluster.setupMaster({args: execArgv}); | |||
There was a problem hiding this comment.
Strangely it didn't work for me without it. Let me check again though.
There was a problem hiding this comment.
Okay figured out this one for the moment and fixed in latest commit. Now I need to figure out how to run code inside the worker process - which I'm not sure how to do since it breaks immediately with --inspect-brk, orphaning the child. Any ideas?
There was a problem hiding this comment.
@joshgav I think you'd have to connect to the debugger to move past the break. There are other tests that exercise --debug-brk, but I don't think any that do it with the cluster module. Maybe this would be better to move to a separate test.
rvagg
force-pushed
the
master
branch
2 times, most recently
from
c133999
to
83c7a88
Compare
|
Should this be visible in in the help text of |
add an --inspect-brk option which breaks on first line of user script. same behavior as old --debug-brk flag. PR-URL: nodejs#8979 Reviewed-By: <tbd> Reviewed-By: <tbd>
|
CI passed, going to land: https://ci.nodejs.org/job/node-test-pull-request/5690/ |
add an --inspect-brk option which breaks on first line of user script. same behavior as old --debug-brk flag. PR-URL: nodejs#8979 Reviewed-By: Eugene Ostroukhov <eostroukhov@chromium.org> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@keybase.io>
|
landed in 6ff3b03 |
|
This is semver-minor, right? Adding the label. |
targos
added
semver-minor
|
This is not landing clearly in v7, there is plan to backport this ? |
|
@italoacasas backported in #11149, which should be followed with #11114 to fix the misaligned help text. Would you do the landing on the 7.x branch, or would I do that? Thanks! |
|
@joshgav for the |
| " --inspect[=host:port] activate inspector on host:port\n" | ||
| " (default: 127.0.0.1:9229)\n" | ||
| " --inspect-brk[=host:port] activate inspector on host:port\n" | ||
| " and break at start of user script\n" |
There was a problem hiding this comment.
--inspect-port was omitted from the docs, see #12581
Checklist
make -j8 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
inspector
Description of change
add
--inspect-brkflag to provide same behavior as--debug-brkflag but for inspector. This allows complete separation of inspector and debugger (old debugger) flags.