src: bump version to v8.0.0 for master #8956
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
c++
|
V8 was already bumped to 5.4, is it going to be bumped again to 5.5+? |
Not just V8. Backwards incompatible changes to src/node.h or other public headers or e.g. upgrading to libuv v2 would warrant bumps too. |
|
@rvagg I think we left it that the bump would happen when a change landed that required it. |
|
OK, no |
danbev
approved these changes
Oct 12, 2016
|
LGTM |
gibfahn
approved these changes
Oct 12, 2016
|
merged @ 762f64a |
rvagg
added a commit
that referenced
this pull request
Oct 18, 2016
PR-URL: #8956 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
merged @ d317184 |
This was referenced Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a
v7.xbranch which owns the v7.x versioning somasterneeds to move on to v8. One of the primary problems we have right now is nightly builds: https://nodejs.org/download/nightly/ they are still coming offmasterso the only v7.x builds you see there are from master and not from the newv7.xbranch. I'd like to have v8.0.0-pre builds coming out ofmasterand start a new nightly stream offv7.x-staging.I don't think we're updating
NODE_MODULE_VERSIONat the same time here, that's going to come when we bump V8 on master right? I've already forgotten how our conversation about that played out, @thealphanerd?