Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readline: concievably typo in readline.js #8953

Closed
wants to merge 1 commit into from
Closed

readline: concievably typo in readline.js #8953

wants to merge 1 commit into from

Conversation

maasencioh
Copy link
Contributor

close #8951

@nodejs-github-bot nodejs-github-bot added the readline Issues and PRs related to the built-in readline module. label Oct 6, 2016
lpinca
lpinca reviewed Oct 6, 2016
View reviewed changes
lib/readline.js
@@ -369,7 +369,7 @@ Interface.prototype._normalWrite = function(b) {

// got one or more newlines; process into "line" events
var lines = string.split(lineEnding);
// either '' or (concievably) the unfinished portion of the next line
// either '' or (conceivable) the unfinished portion of the next line
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be changed to "conceivably"?

@lpinca
Copy link
Member

lpinca commented Oct 6, 2016

@maasencioh thank you for this patch.
Please note that the subsystem is not "doc" but "readline". It would be nice if you could update your commit message to reflect that.

@maasencioh
Copy link
Contributor Author

sorry @lpinca, I though that was like the Angular commit guidelines, I'll change it right the way

@maasencioh maasencioh changed the title doc:concievably typo in readline.js readline: concievably typo in readline.js Oct 6, 2016
@mscdex
Copy link
Contributor

mscdex commented Oct 6, 2016

LGTM

lpinca
lpinca approved these changes Oct 6, 2016
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjihrig cjihrig mentioned this pull request Oct 6, 2016
Closed
addaleax
addaleax approved these changes Oct 6, 2016
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@addaleax
Copy link
Member

addaleax commented Oct 6, 2016 •
edited
Loading

Jenkins is timing out and running CI would feel like checking that the sun hasn’t exploded anyway, so I’m going ahead and landing this:

  • Approvals (LGTM): 5
  • No objections
  • The PR is a typo fix and doesn’t need to be open for the minimum time of 48 or 72 hours
  • All of the requested changes have been made
  • CI won’t work and is unnecessary

@addaleax addaleax self-assigned this Oct 6, 2016
@addaleax
Copy link
Member

addaleax commented Oct 6, 2016

Landed in 7a94e2d, thanks for the contribution!

@addaleax addaleax closed this Oct 6, 2016
addaleax pushed a commit that referenced this pull request Oct 6, 2016
@maasencioh @addaleax
readline: fix concievably typo in readline.js
7a94e2d 
Fixes: #8951
PR-URL: #8953
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@maasencioh
Copy link
Contributor Author

Thanks, it was indeed the silliest first contribution, but I'll try to find one more interesting next time 🚀☀️

@addaleax
Copy link
Member

addaleax commented Oct 6, 2016

@maasencioh It’s still appreciated that you took the time to get familiar with the process here! :)

jasnell pushed a commit that referenced this pull request Oct 6, 2016
@maasencioh @jasnell
readline: fix concievably typo in readline.js
14ddd1a 
Fixes: #8951
PR-URL: #8953
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
@maasencioh @Fishrock123
readline: fix concievably typo in readline.js
4c194ee 
Fixes: #8951
PR-URL: #8953
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@maasencioh maasencioh deleted the maasencioh-readline-typo branch October 20, 2016 14:11
@aliscco aliscco mentioned this pull request Nov 29, 2023
Open
@leonardoadame leonardoadame mentioned this pull request Nov 29, 2023
Open
This was referenced Nov 30, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees

@addaleax addaleax

Labels
readline Issues and PRs related to the built-in readline module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typo in comment in readline.js
8 participants
@maasencioh @lpinca @mscdex @addaleax @targos @cjihrig @MylesBorins @nodejs-github-bot