src: clean up PER_ISOLATE_STRING_PROPERTIES #8207
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnoordhuis
added
c++
| env->as_external()); | ||
| CHECK(maybe.FromJust()); | ||
| { | ||
| auto name = FIXED_ONE_BYTE_STRING(env->isolate(), "title"); |
There was a problem hiding this comment.
I find name confusing. Can we inline it or rename it to title_string?
|
LGTM. |
|
LGTM |
bnoordhuis
force-pushed
the
clean-up-per-isolate-strings
branch
from
c9e553c
to
7e02c15
Compare
|
Renamed the variables. CI: https://ci.nodejs.org/job/node-test-pull-request/3796/ |
|
Still LGTM |
Remove unused strings from the PER_ISOLATE_STRING_PROPERTIES list. PR-URL: nodejs#8207 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Remove strings from the PER_ISOLATE_STRING_PROPERTIES list that are only used once during initialization. It's less expensive to simply create them when needed than turn them into v8::Eternal instances. PR-URL: nodejs#8207 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
bnoordhuis
force-pushed
the
clean-up-per-isolate-strings
branch
from
7e02c15
to
b4ea3a0
Compare
evanlucas
pushed a commit
that referenced
this pull request
Aug 24, 2016
Remove unused strings from the PER_ISOLATE_STRING_PROPERTIES list. PR-URL: #8207 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Aug 24, 2016
Remove strings from the PER_ISOLATE_STRING_PROPERTIES list that are only used once during initialization. It's less expensive to simply create them when needed than turn them into v8::Eternal instances. PR-URL: #8207 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
@bnoordhuis should this be backported? |
|
If it applies and builds, sure. If it doesn't, it's okay to leave it out. |
|
@bnoordhuis this does not land cleanly, leaving it out unless someone wants to backport |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI: https://ci.nodejs.org/job/node-test-pull-request/3776/