Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update windows prerequisites #8049

Closed
wants to merge 1 commit into from

Conversation

bnoordhuis
Copy link
Member

Visual Studio 2013 is no longer supported. Update the Windows build
prerequisites.

Refs: #7484

Visual Studio 2013 is no longer supported.  Update the Windows build
prerequisites.

Refs: nodejs#7484
@bnoordhuis bnoordhuis added doc Issues and PRs related to the documentations. windows Issues and PRs related to the Windows platform. build Issues and PRs related to build files or the CI. labels Aug 10, 2016
@jasnell
Copy link
Member

jasnell commented Aug 10, 2016

LGTM

@joaocgreis
Copy link
Member

Why the update 3? Any VS2015 should do.

@bnoordhuis
Copy link
Member Author

Mostly because I don't want to be chasing bugs in older updates, same when I tell people to upgrade to gcc 4.8.5 when they hit a bug with 4.8.0.

@joaocgreis
Copy link
Member

LGTM

bnoordhuis added a commit to bnoordhuis/io.js that referenced this pull request Aug 11, 2016
We can remove some Visual Studio 2013-specific workarounds now that
support for that compiler has officially been dropped.

Refs: nodejs#7484
Refs: nodejs#8049
bnoordhuis added a commit to bnoordhuis/io.js that referenced this pull request Aug 11, 2016
Support for Visual Studio 2013 has officially been dropped, remove the
build option for that compiler.

Refs: nodejs#7484
Refs: nodejs#8049
jasnell pushed a commit that referenced this pull request Aug 12, 2016
Visual Studio 2013 is no longer supported.  Update the Windows build
prerequisites.

Refs: #7484
PR-URL: #8049
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: João Reis <reis@janeasystems.com>
@jasnell
Copy link
Member

jasnell commented Aug 12, 2016

Landed in b948744

@jasnell jasnell closed this Aug 12, 2016
cjihrig pushed a commit that referenced this pull request Aug 15, 2016
Visual Studio 2013 is no longer supported.  Update the Windows build
prerequisites.

Refs: #7484
PR-URL: #8049
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: João Reis <reis@janeasystems.com>
@cjihrig cjihrig mentioned this pull request Aug 15, 2016
bnoordhuis added a commit to bnoordhuis/io.js that referenced this pull request Sep 23, 2016
We can remove some Visual Studio 2013-specific workarounds now that
support for that compiler has officially been dropped.

PR-URL: nodejs#8067
Refs: nodejs#7484
Refs: nodejs#8049
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joao Reis <reis@janeasystems.com>
bnoordhuis added a commit to bnoordhuis/io.js that referenced this pull request Sep 23, 2016
Support for Visual Studio 2013 has officially been dropped, remove the
build option for that compiler.

PR-URL: nodejs#8067
Refs: nodejs#7484
Refs: nodejs#8049
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joao Reis <reis@janeasystems.com>
jasnell pushed a commit that referenced this pull request Sep 29, 2016
We can remove some Visual Studio 2013-specific workarounds now that
support for that compiler has officially been dropped.

PR-URL: #8067
Refs: #7484
Refs: #8049
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joao Reis <reis@janeasystems.com>
jasnell pushed a commit that referenced this pull request Sep 29, 2016
Support for Visual Studio 2013 has officially been dropped, remove the
build option for that compiler.

PR-URL: #8067
Refs: #7484
Refs: #8049
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joao Reis <reis@janeasystems.com>
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
We can remove some Visual Studio 2013-specific workarounds now that
support for that compiler has officially been dropped.

PR-URL: #8067
Refs: #7484
Refs: #8049
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joao Reis <reis@janeasystems.com>
Fishrock123 pushed a commit that referenced this pull request Oct 11, 2016
Support for Visual Studio 2013 has officially been dropped, remove the
build option for that compiler.

PR-URL: #8067
Refs: #7484
Refs: #8049
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joao Reis <reis@janeasystems.com>
@gibfahn gibfahn mentioned this pull request Nov 7, 2017
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants