build: add node_module_version to config.gypi #8027
Conversation
Work around spec violations in V8 where it checks that `this == NULL`. GCC 6 started exploiting this particular kind of UB, resulting in runtime crashes. Fixes: nodejs#6724 PR-URL: nodejs#6737 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Back-port commit 76f40f7 ("test: stronger crypto in test fixtures") from
the master branch.
Pushes back the expiration date of test/fixtures/keys/ca2-crl.pem to
2018, fixing a CRL_HAS_EXPIRED error in simple/test-tls-server-verify.
Fixes: nodejs#7194
PR-URL: nodejs#7195
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
nodejs-github-bot
added
the
build
|
This is #7808 for v0.12 |
saper
force-pushed
the
node_module_vesion/v0.12
branch
2 times, most recently
from
3bda6d3
to
aab8896
Compare
|
I believe PRs need to target the relevant |
|
I believe that after today's LTS discussion it was decided that this would land in v4.x but we were not planning to backport to v0.10 or v0.12 /cc @nodejs/lts @rvagg |
|
@mscdex I was checking of course I am more than happy to cherry pick this somewhere else. |
|
@saper Perhaps you're looking at old release branches? Each major version (including v0.10 and v0.12) has its own |
|
Most probably, yes. Will try to fix that, thanks for pointing that out. |
Can you reconsider? This change makes it possible for add-on authors to detect the ABI version without gross v0.10/v0.12-specific hacks in their binding.gyp. |
|
Yeah, I don't think anyone felt that strongly about not having it, it was just more a bias towards leaving it as is since both are coming up to end-of-life soon. If there's a good enough justification then why not? :-) |
saper
changed the title
saper
force-pushed
the
node_module_vesion/v0.12
branch
from
aab8896
to
468527f
Compare
saper
force-pushed
the
node_module_vesion/v0.12
branch
from
468527f
to
0583134
Compare
Enable targetting of a different node version than the currently running one when building binary modules. Based on nodejs/node@410296c37 PR-URL: nodejs#8027 Ref: nodejs#7808 Ref: nodejs/node-gyp#855
saper
force-pushed
the
node_module_vesion/v0.12
branch
from
0583134
to
addfeaa
Compare
Enable targetting of a different node version than the currently running one when building binary modules. Based on nodejs/node@410296c37 PR-URL: nodejs#8171 Ref: nodejs#8027 Ref: nodejs#7808 Ref: nodejs/node-gyp#855
Enable targetting of a different node version than the currently running one when building binary modules. Based on 410296c37 PR-URL: #8171 Ref: #8027 Ref: #7808 Ref: nodejs/node-gyp#855 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
rvagg
force-pushed
the
v0.12-staging
branch
from
c5b01a1
to
1ba6d16
Compare
Enable targetting of a different node version than the currently running one when building binary modules. Based on 410296c37 PR-URL: #8171 Ref: #8027 Ref: #7808 Ref: nodejs/node-gyp#855 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
@nodejs/lts Is this still on track for inclusion in a v0.12 release? |
|
LGTM with green CI. Once it lands in v0.12-staging it should go out with whatever the next v0.12 release happens to be. |
Enable targetting of a different node version than the currently running one when building binary modules. Based on 410296c37 PR-URL: #8171 Ref: #8027 Ref: #7808 Ref: nodejs/node-gyp#855 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Enable targetting of a different node version than the currently running one when building binary modules. Based on 410296c37 PR-URL: #8171 Ref: #8027 Ref: #7808 Ref: nodejs/node-gyp#855 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
not gonna make it sorry |
|
@rvagg I think this is still good to go, it just needs a rebase. I can file a rebased PR if you want. |
Enable targetting of a different node version than the currently running one when building binary modules. Based on nodejs/node@410296c37 PR-URL: nodejs#8027 Ref: nodejs#7808 Ref: nodejs/node-gyp#855
|
I have pushed the rebase to the branch, there were no conflicts. |
Enable targetting of a different node version than the currently running one when building binary modules. Based on nodejs/node@410296c37 PR-URL: nodejs#8027 Ref: nodejs#7808 Ref: nodejs/node-gyp#855
|
This PR still seems to contain unrelated changes. I've opened #10355 as a cherry-pick of your commit on top of v0.12-staging. |
|
thanks, @bnoordhuis ! I appreciate that. |
Enable targetting of a different node version than
the currently running one when building binary modules.
Based on 410296c37
PR-URL: nodejs/node-gyp#855