Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: favor === over == #8000

Closed
wants to merge 1 commit into from
Closed

benchmark: favor === over == #8000

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 6, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

benchmark

Description of change

Refs: #7961 (comment)

@Trott Trott added the benchmark Issues and PRs related to the benchmark subsystem. label Aug 6, 2016
@Trott
Copy link
Member Author

Trott commented Aug 6, 2016

/cc @AndreasMadsen

@mscdex
Copy link
Contributor

mscdex commented Aug 6, 2016

LGTM

@mscdex
Copy link
Contributor

mscdex commented Aug 6, 2016

linter: https://ci.nodejs.org/job/node-test-linter/3615/

@AndreasMadsen
Copy link
Member

LGTM, but I'm not sure how important it is, if we can't make it a formal rule.

@mscdex
Copy link
Contributor

mscdex commented Aug 6, 2016

@AndreasMadsen Well, we can't create a linter rule for it since there are legitimate uses for ==.

@Trott
Copy link
Member Author

Trott commented Aug 6, 2016 •
edited
Loading

ESLint allows for exceptions when comparing to null, comparing literals, and using typeof. That will cover most of the cases. Any other legitimate cases, we can disable the lint rule with comments. So I think we should be able to do it. But I prefer to do small and manageable chunks of code at a time...

We could also enable it only for specific directories like benchmark.

So if we want this to be lint-enforced, there are definitely options.

@addaleax
Copy link
Member

addaleax commented Aug 7, 2016

LGTM

3 similar comments
@cjihrig
Copy link
Contributor

cjihrig commented Aug 8, 2016

LGTM

@jasnell
Copy link
Member

jasnell commented Aug 8, 2016

LGTM

@jbergstroem
Copy link
Member

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Aug 9, 2016
@Trott
benchmark: favor === over ==
ae25ed3 
Refs: nodejs#7961 (comment)
PR-URL: nodejs#8000
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@Trott
Copy link
Member Author

Trott commented Aug 9, 2016

Landed in ae25ed3

@Trott Trott closed this Aug 9, 2016
@cjihrig cjihrig mentioned this pull request Aug 10, 2016
Closed
cjihrig pushed a commit that referenced this pull request Aug 10, 2016
@Trott @cjihrig
benchmark: favor === over ==
0d4b046 
Refs: #7961 (comment)
PR-URL: #8000
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Andreas Madsen <amwebdk@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
@cjihrig cjihrig mentioned this pull request Aug 11, 2016
Merged
@Trott Trott deleted the eqeqeq branch January 13, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
benchmark Issues and PRs related to the benchmark subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Trott @mscdex @AndreasMadsen @addaleax @cjihrig @jasnell @jbergstroem @MylesBorins