Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: fix V8 5.1 tests #7488

Closed
wants to merge 1 commit into from
Closed

deps: fix V8 5.1 tests #7488

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Jun 29, 2016

Checklist
  • make test-v8 passes
  • commit message follows commit guidelines
Affected core subsystem(s)

v8

Description of change

Restore whitespaces in *.golden files. They were lost when I landed the
V8 5.1 update.

Fixes: #7477

Restore whitespaces in *.golden files. They were lost when I landed the
V8 5.1 update.

Fixes: nodejs#7477
@targos targos added the v8 engine Issues and PRs related to the V8 dependency. label Jun 29, 2016
@nodejs-github-bot nodejs-github-bot added the lib / src Issues and PRs related to general changes in the lib or src directory. label Jun 29, 2016
@targos targos removed the lib / src Issues and PRs related to general changes in the lib or src directory. label Jun 29, 2016
@MylesBorins
Copy link
Contributor

WOW. Whitespace causing this pain is pretty wonderful.

ci: https://ci.nodejs.org/job/node-test-commit-v8-linux/165/

@ofrobots
Copy link
Contributor

😢 As mentioned in another thread recently, we should really consider landing deps changes without --whitespace=fix

@mscdex mscdex added the test Issues and PRs related to the tests. label Jun 29, 2016
@MylesBorins
Copy link
Contributor

benchmark is green. I'm +1 on revisiting whitespace-fix for dependnecies... thoughts @nodejs/ctc?

@mscdex
Copy link
Contributor

mscdex commented Jun 29, 2016

I think I agree.

@mhdawson
Copy link
Member

LGTM

targos added a commit to targos/node that referenced this pull request Jun 30, 2016
Restore whitespaces in *.golden files. They were lost when I landed the
V8 5.1 update and are needed for the tests to pass.

Fixes: nodejs#7477
PR-URL: nodejs#7488
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@targos
Copy link
Member Author

targos commented Jun 30, 2016

landed in dc17432

@Fishrock123
Copy link
Contributor

Please add the relevant label(s) for master-only commits. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests. v8 engine Issues and PRs related to the V8 dependency.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

207 failures in v8 tests within node tree
7 participants