-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable line ending normalization in git, not in the linter #7019
Closed
Closed
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
a037243
meta: enable git auto end-of-line normalization
joaocgreis bed497f
tools: do not enforce a linebreak style in linter
joaocgreis be486b8
fixup meta: exclude a v8 test
joaocgreis 86bd27a
fixup tools: linebreak-style: 0
joaocgreis a4298de
fixup meta: enable text only for selected extensions
joaocgreis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,45 @@ | ||
| * -text | ||
| ./* text=auto | ||
| *.bat text | ||
| *.c text | ||
| *.cc text | ||
| *.css text | ||
| *.d text | ||
| *.def text | ||
| *.gyp text | ||
| *.gypi text | ||
| *.h text | ||
| *.html text | ||
| *.inc text | ||
| *.js text | ||
| *.json text | ||
| *.man text | ||
| *.manifest text | ||
| *.md text | ||
| *.out text | ||
| *.pl text | ||
| *.py text | ||
| *.rb text | ||
| *.rc text | ||
| *.sln text | ||
| *.status text | ||
| *.txt text | ||
| *.vcxproj text | ||
| *.wixproj text | ||
| *.wxl text | ||
| *.wxs text | ||
| *.yml text | ||
| tools/msvs/npm/npmrc text | ||
| deps/v8/test/mjsunit/regress/regress-2825.js -text | ||
|
|
||
| test/fixtures/* -text | ||
| vcbuild.bat text eol=crlf | ||
|
|
||
| # Exceptions for dependencies committed with CRLF line endings | ||
| # Should be removed when the files are updated | ||
| deps/npm/node_modules/node-gyp/gyp/gyp.bat -text | ||
| deps/npm/node_modules/node-gyp/gyp/samples/samples.bat -text | ||
| deps/uv/docs/make.bat -text | ||
| deps/v8/test/message/regress/regress-73.js -text | ||
| deps/zlib/contrib/minizip/ChangeLogUnzip -text | ||
| tools/gyp/gyp.bat -text | ||
| tools/gyp/samples/samples.bat -text |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than removing this rule, can you change its value to the default value? The net result would be the same as removing it, but having the explicit value might prevent people in the future from readding the "wrong" rule (at least they might be prompted to look at the commit history for that line).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
unixis the default value.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The options with this rule are
unix,windows, or disabling/removing the rule. If we want to leave the line there and have the rule explicitly disabled, change2to0. We don't do that for any other rules, though, if that matters.