benchmark: clean up common.js #662
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
LGTM what sort of changes do you want to add with the upcoming PR? |
| var path = require('path'); | ||
| var assert = require('assert'); | ||
| var spawn = require('child_process').spawn; |
There was a problem hiding this comment.
Minor style nit: I don't think it's a hard rule but imports tend to be sorted in alphabetical order.
This commit cleans up `benchmark/common.js` with a few generic changes such as the following: - declare all `require()`'d libraries at the top instead of in the middle - add some empty whitespace where it helps readability - changes ambiguous variable names - standardizes most if / else blocks - missing semicolons
brendanashworth
force-pushed
the
clean-up-benchmark-common
branch
from
aee5848
to
5e16c62
Compare
|
Fixed from @bnoordhuis's comment. @micnic maybe some special plotting goodness 😄 |
|
LGTM |
brendanashworth
added a commit
that referenced
this pull request
Feb 2, 2015
This commit cleans up `benchmark/common.js` with a few generic changes such as the following: - declare all `require()`'d libraries at the top instead of in the middle - add some empty whitespace where it helps readability - changes ambiguous variable names - standardizes most if / else blocks - missing semicolons PR-URL: #662 Reviewed-By: Nicu Micleușanu <micnic90@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
|
Landed in 89dd8e0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit cleans up
benchmark/common.jswith a few generic changessuch as the following:
require()'d libraries at the top instead of in themiddle
This is sort of the prep for an up and coming PR I'm writing, but I just couldn't work with the code as it was.