Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: DCO anchor that doesn't change #6257

Closed
wants to merge 1 commit into from
Closed

doc: DCO anchor that doesn't change #6257

wants to merge 1 commit into from

Conversation

williamkapke
Copy link
Contributor

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Description of change

The DCO (Developer's Certificate of Origin) has a version number in it so whenever there is an update to the version, the hash (#) links break. This change just adds an anchor without the version number on it.

@williamkapke
Copy link
Contributor Author

After this is merged, I can fix nodejs/TSC#73

@addaleax
Copy link
Member

LGTM but I think you want to add a doc:  prefix to the commit message.

@lpinca
Copy link
Member

lpinca commented Apr 18, 2016

@addaleax correct but I guess it can be added by whoever lands this.

@addaleax addaleax added the doc Issues and PRs related to the documentations. label Apr 18, 2016
@addaleax
Copy link
Member

@lpinca Yeah, just not sure how urgent this is and @williamkapke can probably fix this. Also, I think there should be a full name in the Author: field (unless desired otherwise), and while that could be done on landing too, it might be nice to leave that to the author :)

@lpinca
Copy link
Member

lpinca commented Apr 18, 2016

Totally agree with that :)

@cjihrig
Copy link
Contributor

cjihrig commented Apr 18, 2016

LGTM

@williamkapke williamkapke changed the title DCO anchor that doesn't change doc: DCO anchor that doesn't change Apr 18, 2016
@jasnell
Copy link
Member

jasnell commented Apr 18, 2016

LGTM

@williamkapke
Copy link
Contributor Author

Updated with doc: prefix and specified full name in Author:

jasnell pushed a commit that referenced this pull request Apr 18, 2016
PR-URL: #6257
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Apr 18, 2016

Landed in 71801b7

@jasnell jasnell closed this Apr 18, 2016
MylesBorins pushed a commit that referenced this pull request Apr 19, 2016
PR-URL: #6257
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
PR-URL: #6257
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
PR-URL: #6257
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 20, 2016
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
PR-URL: #6257
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 21, 2016
PR-URL: #6257
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 21, 2016
PR-URL: #6257
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
joelostrowski pushed a commit to joelostrowski/node that referenced this pull request Apr 25, 2016
PR-URL: nodejs#6257
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Apr 26, 2016
PR-URL: #6257
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 1, 2016
PR-URL: #6257
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jun 24, 2016
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
PR-URL: #6257
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
PR-URL: #6257
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Trott pushed a commit that referenced this pull request Sep 22, 2019
Remove the number '11' as the suffix anchor id for the 'Developer's
Certificate of Origin 1.1'.

PR-URL: #29468
Refs: #6257
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Sep 23, 2019
Remove the number '11' as the suffix anchor id for the 'Developer's
Certificate of Origin 1.1'.

PR-URL: #29468
Refs: #6257
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR pushed a commit that referenced this pull request Sep 25, 2019
Remove the number '11' as the suffix anchor id for the 'Developer's
Certificate of Origin 1.1'.

PR-URL: #29468
Refs: #6257
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants