process: add process.gracefulExit() #6175
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides a deferrable, async alternative to process.exit(). Whereas
process.exit() exits the process as quickly as possible,
process.gracefulExit(), by default, will not exit until the next
tick of the event loop (scheduled by setImmediate). A callback
function can be provided to customize the exit process and invoke
the actual exit when desired or appropriate to do so.
Exits with code `1` on the next tick of the event loop:
```js
process.gracefulExit(1);
```
Exits with code '0' on `process.nextTick()`:
```js
process.gracefulExit(1, (code, exit) => {
console.log('exiting gracefully on next tick');
process.nextTick(() => exit(0));
});
```
Immediately exit if the graceful exit is not completed within 10 seconds:
```js
process.gracefulExit(0, 10000, (code, exit) => {
// Wait, do nothing. don't call exit.
});
```
The implementation is such that `process.exit()` is still called, so
process.on('exit') handlers will be invoked.
In cluster/child-processes with IPC, this does *not* take the place
of process.disconnect().
jasnell
added
semver-minor
|
Isn't this something we can (should?) leave to userland? |
| process.gracefulExit = function(code, timeout, cb) { | ||
| if (process._exiting || process._exitingGracefully) | ||
| return; | ||
| process._exitingGracefully = true; |
|
I think this is something that can be done from userland. If we include it in core - I think it would be useful to add cleanup listeners process.on("gracefulExit", (cb) => {
// call cb to mark cleanup done
});Or something like that. |
|
This is basically |
|
Basically scratched an itch that I had in a couple apps. I've had this around for a bit and wanted to at least float the idea. Not that concerned if it doesn't land, but had it on my todo list for a while to float it and see. |
|
I think this should probably be left to userland as well. |
|
Works for me! Thanks all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
process
Description of change
Provides a deferrable, async alternative to process.exit(). Whereas process.exit() exits the process as quickly as possible, process.gracefulExit(), by default, will not exit until the next tick of the event loop (scheduled by setImmediate). A callback function can be provided to customize the exit process and invoke the actual exit when desired or appropriate to do so.
Exits with code
1on the next tick of the event loop:Exits with code '0' on
process.nextTick():Immediately exit if the graceful exit is not completed within 10 seconds:
The implementation is such that
process.exit()is still called ultimately, so process.on('exit') handlers will be invoked.In cluster/child-processes with IPC, this does not take the place of process.disconnect().
Note: to a degree this is speculative and yes, it is possible for this to live in userland.