doc: add copy about how to curl SHA256.txt #6120
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We may also want to include information about the armored version of the SHA (perhaps we should be suggesting that by default). We might also want to include copy stating that on osx you want to substitute Based on review I will update the copy |
|
seems good to me |
|
nit: would prefer to avoid the use of |
Currently we include instructions on how to check the sha of a downloaded tar-ball, but do not include instruction on how to get the `SHA256.txt` file. This has led to confusion with people thinking that the SHA256.txt is included in that tarball. This commit includes instructions on how to use curl to download the `SHA256.txt` prior to the instructions on how to verify the sha. ref: nodejs/help#113 ref: nodejs/help#137
MylesBorins
force-pushed
the
update-sha-verification-copy
branch
from
98cf2d5
to
3b4d95c
Compare
|
LGTM |
|
@jasnell addressed nit. |
|
LGTM |
|
+1 |
jasnell
pushed a commit
that referenced
this pull request
Apr 10, 2016
Currently we include instructions on how to check the sha of a downloaded tar-ball, but do not include instruction on how to get the `SHA256.txt` file. This has led to confusion with people thinking that the SHA256.txt is included in that tarball. This commit includes instructions on how to use curl to download the `SHA256.txt` prior to the instructions on how to verify the sha. Refs: nodejs/help#113 Refs: nodejs/help#137 PR-URL: #6120 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 59d23ad |
MylesBorins
pushed a commit
that referenced
this pull request
Apr 11, 2016
Currently we include instructions on how to check the sha of a downloaded tar-ball, but do not include instruction on how to get the `SHA256.txt` file. This has led to confusion with people thinking that the SHA256.txt is included in that tarball. This commit includes instructions on how to use curl to download the `SHA256.txt` prior to the instructions on how to verify the sha. Refs: nodejs/help#113 Refs: nodejs/help#137 PR-URL: #6120 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Apr 19, 2016
Currently we include instructions on how to check the sha of a downloaded tar-ball, but do not include instruction on how to get the `SHA256.txt` file. This has led to confusion with people thinking that the SHA256.txt is included in that tarball. This commit includes instructions on how to use curl to download the `SHA256.txt` prior to the instructions on how to verify the sha. Refs: nodejs/help#113 Refs: nodejs/help#137 PR-URL: #6120 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 20, 2016
Currently we include instructions on how to check the sha of a downloaded tar-ball, but do not include instruction on how to get the `SHA256.txt` file. This has led to confusion with people thinking that the SHA256.txt is included in that tarball. This commit includes instructions on how to use curl to download the `SHA256.txt` prior to the instructions on how to verify the sha. Refs: nodejs/help#113 Refs: nodejs/help#137 PR-URL: #6120 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Closed
MylesBorins
pushed a commit
that referenced
this pull request
Apr 20, 2016
Currently we include instructions on how to check the sha of a downloaded tar-ball, but do not include instruction on how to get the `SHA256.txt` file. This has led to confusion with people thinking that the SHA256.txt is included in that tarball. This commit includes instructions on how to use curl to download the `SHA256.txt` prior to the instructions on how to verify the sha. Refs: nodejs/help#113 Refs: nodejs/help#137 PR-URL: #6120 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Apr 26, 2016
Currently we include instructions on how to check the sha of a downloaded tar-ball, but do not include instruction on how to get the `SHA256.txt` file. This has led to confusion with people thinking that the SHA256.txt is included in that tarball. This commit includes instructions on how to use curl to download the `SHA256.txt` prior to the instructions on how to verify the sha. Refs: nodejs/help#113 Refs: nodejs/help#137 PR-URL: #6120 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we include instructions on how to check the sha of a
downloaded tar-ball, but do not include instruction on how to
get the
SHA256.txtfile. This has led to confusion with peoplethinking that the SHA256.txt is included in that tarball.
This commit includes instructions on how to use curl to download the
SHA256.txtprior to the instructions on how to verify the sha.ref: nodejs/help#113
ref: nodejs/help#137