benchmark: use options.filename when, for esm, require.main.filename is undefined #55027
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
benchmark
RedYetiDev
added
esm
|
This feels quite hacky - can't we just take an explicit filename in the |
iambumblehead
force-pushed
the
benchmark-detect-filename-esm-runtime
branch
from
99999cc
to
1e2fab5
Compare
iambumblehead
changed the title
iambumblehead
force-pushed
the
benchmark-detect-filename-esm-runtime
branch
from
1e2fab5
to
06e95fb
Compare
|
@joyeecheung thank you for the comment. The commit is amended to use explicit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes allow
benchmark/common.jsto be imported and used by esm scripts.Advice, suggestions and any input at all are welcome. Thank you for reading me :)