repl: runtime deprecate instantiating without new

[RedYetiDev]

Followup #54842

This PR runtime-deprecates instantiating the REPL classes without the new keyword.

[codecov]

Codecov Report

Attention: Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.05%. Comparing base (c3a7b29) to head (1ada6a0).
Report is 31 commits behind head on main.

Files with missing lines	Patch %	Lines
lib/repl.js	75.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #54869      +/-   ##
==========================================
+ Coverage   87.91%   88.05%   +0.14%     
==========================================
  Files         651      651              
  Lines      183354   183413      +59     
  Branches    35719    35829     +110     
==========================================
+ Hits       161190   161506     +316     
+ Misses      15446    15158     -288     
- Partials     6718     6749      +31     

Files with missing lines	Coverage Δ
lib/internal/util.js	96.59% <100.00%> (-0.16%)	⬇️
lib/repl.js	94.80% <75.00%> (-0.06%)	⬇️

... and 74 files with indirect coverage changes

[LiviaMedeiros]

LGTM with updates to existing codebase. Example:

node/test/parallel/test-repl-preview-without-inspector.js

Line 68 in 741004a

const repl = REPLServer({

[RedYetiDev]

CC @nodejs/repl

[jasnell]

I think we need a documentation-only deprecation on this first and we need to get a sense of how impactful a runtime deprecation would be on the ecosystem here. Given the nature of the repl module, this would most likely lead to a fair bit of console output noise for modules that are using the repl and users may not actually be able to do anything about it. So let's be careful.

[RedYetiDev]

I think we need a documentation-only deprecation on this first and we need to get a sense of how impactful a runtime deprecation would be on the ecosystem here.

FWIW It has already been doc-deprecated (but very recently).

[RedYetiDev]

@jasnell would you be opposed to landing this in v23 entirely-I'm happy to wait until v24?

[jasnell]

I prefer to wait

[RedYetiDev]

Got it. While I'd prefer for this to release in v23, I respect your opinion. I'll look into other optimizations in the meantime.

[RedYetiDev]

@nodejs/tsc per nodejs/Release#1034

---

My main question is: is this something that could happen in v23? Or should it wait (like @jasnell suggested)?

[benjamingr]

I agree with James on this

[anonrig]

Let's give people some time to make arrangements, before polluting their console.

[mcollina]

lgtm