Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: reland "Remove --harmony-rab-gsab" #53755

Closed
wants to merge 2 commits into from

Commits on Jul 7, 2024

  1. deps: V8: cherry-pick e061cf9970d9

    Original commit message:
    
        [arraybuffers] initialize max byte length of empty array buffers
    
        Without initializing the max byte length field, any empty array
        buffer captured in the snapshot can make the snapshot unreproducible.
    
        Refs: nodejs#53579
    
        Change-Id: I2489ab2e57ecbb405ec431a87d0acc92822b777c
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5662576
        Reviewed-by: Marja Hölttä <marja@chromium.org>
        Commit-Queue: Marja Hölttä <marja@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#94754}
    
    Refs: v8/v8@e061cf9
    joyeecheung committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    1db1737 View commit details
    Browse the repository at this point in the history
  2. deps: V8: cherry-pick 9ebca66a5740

    Original commit message:
    
        [rab/gsab] Remove --harmony-rab-gsab (has been on by default for a while)
    
        Bug: v8:11111
        Change-Id: Ie74e7737f3e2e8730820cf00f1cbc7ae02b515af
        Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5516580
        Commit-Queue: Marja Hölttä <marja@chromium.org>
        Reviewed-by: Camillo Bruni <cbruni@chromium.org>
        Reviewed-by: Shu-yu Guo <syg@chromium.org>
        Reviewed-by: Nico Hartmann <nicohartmann@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#93848}
    
    Refs: v8/v8@9ebca66
    PR-URL: nodejs#53522
    Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
    legendecas authored and joyeecheung committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    7b774d6 View commit details
    Browse the repository at this point in the history