Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "vm,src: add property query interceptors" #53348

Merged
merged 2 commits into from
Jun 6, 2024
Merged

Revert "vm,src: add property query interceptors" #53348

merged 2 commits into from
Jun 6, 2024

Conversation

targos
Copy link
Member

@targos targos commented Jun 5, 2024 •
edited
Loading

This reverts commit d1f18b0.

Closes: #53346

Reverts PR #53172

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem. labels Jun 5, 2024
@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Jun 5, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 5, 2024

Fast-track has been requested by @targos. Please 👍 to approve.

@targos targos added dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. labels Jun 5, 2024
@targos targos mentioned this pull request Jun 5, 2024
Closed
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 5, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 5, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59661/

@targos targos added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Jun 5, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59669/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/59671/

@targos targos added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 6, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 6, 2024
@nodejs-github-bot nodejs-github-bot merged commit 35b8e5c into nodejs:main Jun 6, 2024
59 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 35b8e5c

@targos targos deleted the fix-regression branch June 10, 2024 09:42
@legendecas legendecas mentioned this pull request Jun 20, 2024
Closed
EliphazBouye pushed a commit to EliphazBouye/node that referenced this pull request Jun 20, 2024
@targos @EliphazBouye
Revert "vm,src: add property query interceptors"
ffa2586 
This reverts commit d1f18b0.

Closes: nodejs#53346
PR-URL: nodejs#53348
Fixes: nodejs#53346
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
bmeck pushed a commit to bmeck/node that referenced this pull request Jun 22, 2024
@targos @bmeck
Revert "vm,src: add property query interceptors"
91a117e 
This reverts commit d1f18b0.

Closes: nodejs#53346
PR-URL: nodejs#53348
Fixes: nodejs#53346
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@H4ad H4ad H4ad approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

vm module regression
4 participants
@targos @nodejs-github-bot @richardlau @H4ad