Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "test_runner: do not invoke after hook when test is empty" #51998

Closed
wants to merge 2 commits into from
Closed

Revert "test_runner: do not invoke after hook when test is empty" #51998

wants to merge 2 commits into from
+13 −13

Commits on Mar 7, 2024

  1. Revert "test_runner: do not invoke after hook when test is empty" 

    This reverts commit a53fd95.

This caused a regression because the original issue this commit
was attempting to fix is not a bug. The after() hook should
always run.

Fixes: nodejs#51997
    @cjihrig
    cjihrig committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    c39a545 View commit details
    Browse the repository at this point in the history

  2. test: add regression test for test_runner after hook 

    Refs: nodejs#51997
    @cjihrig
    cjihrig committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    cfccb99 View commit details
    Browse the repository at this point in the history