doc: clarify dgram socket.send() multi-buffer support #5130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Good step in docs. Since tbh I was just using |
| The `buf` argument is a [`Buffer`] object containing the message. The `offset` | ||
| and `length` specify the offset within the `Buffer` where the message begins | ||
| and the number of bytes in the message, respectively. With messages that | ||
| The `msg` argument containins the message the message to be sent. |
There was a problem hiding this comment.
the message the message -> the message
|
One small typographical fix but LGTM otherwise. |
r-52
added
dgram
mcollina
force-pushed
the
new-dgram-docs
branch
from
d429dc1
to
aeb59f1
Compare
|
LGTM |
|
@jasnell yes. Should I flag it anyhow in the commit message? Anyway, I've updated the typo. Any other fix? |
mcollina
added
semver-minor
|
I've removed the LTS flag and added the semver-minor label. |
mcollina
force-pushed
the
new-dgram-docs
branch
from
aeb59f1
to
82107df
Compare
Fixes: nodejs#5124 See: nodejs#4374 PR-URL: nodejs#5130 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
mcollina
force-pushed
the
new-dgram-docs
branch
from
82107df
to
f8a7cff
Compare
|
This actual doc change does not need to be labeled semver-minor, we just need to make sure it doesn't land in v4 |
jasnell
added
dont-land-on-v4.x
and removed
semver-minor
|
Landed as 76bc4c7. |
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Fixes: nodejs#5124 See: nodejs#4374 PR-URL: nodejs#5130 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5124
@Trott @eljefedelrodeodeljefe @silverwind @nodejs/documentation Let me know if I need to change this more.