src,lib: use node_path for path.resolve #51295
Closed
+161
−270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
c++
github-actions
bot
removed
the
request-ci
|
@tniessen I see most of the failures are related to parallel.test-crypto-keygen-key-objects which seems unrelated to this PR (I guess). Do you know if these crypto functions use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm opening it to assert all the changes made in #50758 as suggested in (#50758 (comment)).
Please, do not merge this PR
This PR intends to validate if the C++ implementation matches the JS one, so I can proceed with #50758 PR.
Since I haven't created the
path.win32implementation, I had to move some tests to Windows only.Note: I'll exclude upstream feat/pm-resolve branch soon as my PR lands.