Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crypto: have fixed NodeBIOs return EOF. #5105

Closed
wants to merge 1 commit into from
Closed

crypto: have fixed NodeBIOs return EOF. #5105

wants to merge 1 commit into from

Commits on Feb 11, 2016

  1. crypto: have fixed NodeBIOs return EOF. 

    Prior to this change, the NodeBIO objects used to wrap fixed data had
`num` equal to -1. This caused them to return -1 and set the retry flags
when they ran out of data. Since the data is fixed, that's incorrect.
Instead they should return zero to signal EOF.

This change adds a new, static function, NodeBIO::NewFixed to create a
BIO that wraps fixed data and which returns zero when exhausted.

The practical impact of this is limited since most (all?) the parsing
functions that these BIOs get passed to consider any return value less
than one to be EOF and ignore the retry flags anyway.
    @agl
    agl committed Feb 11, 2016
    Configuration menu
    Copy the full SHA
    26f2daf View commit details
    Browse the repository at this point in the history