Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: fix primordials typings #49895

Merged
merged 1 commit into from
Sep 29, 2023
Merged

lib: fix primordials typings #49895

merged 1 commit into from
Sep 29, 2023

Conversation

SamVerschueren
Copy link
Contributor

Hey 👋

I noticed that in the primordials.js, SymbolDispose and SymbolAsyncDispose are defined as

primordials.SymbolDispose ??= primordials.SymbolFor('nodejs.dispose');
primordials.SymbolAsyncDispose ??= primordials.SymbolFor('nodejs.asyncDispose');

The result of primordials.SymbolFor is a symbol. Currently these two properties are defined as SymbolConstructor (typeof Symbol). I think this is incorrect and should be updated to symbol instead.

@anonrig anonrig requested a review from MoLow September 27, 2023 13:55
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Sep 28, 2023
@MoLow MoLow added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 28, 2023
anonrig
anonrig approved these changes Sep 28, 2023
View reviewed changes
Copy link
Member

@anonrig anonrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 29, 2023
@nodejs-github-bot nodejs-github-bot merged commit 1b96975 into nodejs:main Sep 29, 2023
31 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 1b96975

@RafaelGSS RafaelGSS mentioned this pull request Oct 9, 2023
Merged
alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023
@SamVerschueren @alexfernandez
lib: fix primordials typings
d14e7d8 
PR-URL: nodejs#49895
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
targos pushed a commit that referenced this pull request Nov 11, 2023
@SamVerschueren @targos
lib: fix primordials typings
d9eda67 
PR-URL: #49895
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
@targos targos mentioned this pull request Nov 12, 2023
Merged
@juanarbol juanarbol mentioned this pull request Dec 6, 2023
Merged
debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024
@SamVerschueren @debadree25
lib: fix primordials typings
f5255f9 
PR-URL: nodejs#49895
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@MoLow MoLow MoLow approved these changes

@aduh95 aduh95 aduh95 approved these changes

@atlowChemi atlowChemi atlowChemi approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. typings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SamVerschueren @nodejs-github-bot @anonrig @MoLow @aduh95 @atlowChemi