Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: caveat unavailability of import.meta.resolve in custom loaders #49242

Merged
merged 2 commits into from
Aug 19, 2023
Merged

doc: caveat unavailability of import.meta.resolve in custom loaders #49242

merged 2 commits into from
Aug 19, 2023

Conversation

JakobJingleheimer
Copy link
Contributor

closes #49198

@JakobJingleheimer JakobJingleheimer self-assigned this Aug 19, 2023
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/loaders
  • @nodejs/modules

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. labels Aug 19, 2023
@JakobJingleheimer JakobJingleheimer marked this pull request as ready for review August 19, 2023 12:20
@JakobJingleheimer JakobJingleheimer added the fast-track PRs that do not need to wait for 48 hours to land. label Aug 19, 2023
@github-actions
Copy link
Contributor

Fast-track has been requested by @JakobJingleheimer. Please 👍 to approve.

@aduh95
Copy link
Contributor

aduh95 commented Aug 19, 2023

Can you fix the linter error please?

@JakobJingleheimer
Copy link
Contributor Author

Gah, friggin line-wrap. It's fixed

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Aug 19, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 19, 2023
@nodejs-github-bot nodejs-github-bot merged commit 41a3a1d into nodejs:main Aug 19, 2023
23 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 41a3a1d

@JakobJingleheimer JakobJingleheimer deleted the doc/add-loader-caveat-to-import-meta-resolve- branch August 20, 2023 12:52
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@JakobJingleheimer @UlisesGascon
doc: caveat unavailability of import.meta.resolve in custom loaders
5a363bb 
PR-URL: #49242
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
@UlisesGascon UlisesGascon mentioned this pull request Sep 10, 2023
Merged
targos pushed a commit to targos/node that referenced this pull request Nov 11, 2023
@JakobJingleheimer @targos
doc: caveat unavailability of import.meta.resolve in custom loaders
222a378 
PR-URL: nodejs#49242
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
@targos targos mentioned this pull request Nov 11, 2023
Closed
@targos targos added the backported-to-v18.x PRs backported to the v18.x-staging branch. label Nov 23, 2023
targos pushed a commit that referenced this pull request Nov 23, 2023
@JakobJingleheimer @targos
doc: caveat unavailability of import.meta.resolve in custom loaders
58eaf3f 
PR-URL: #49242
Backport-PR-URL: #50669
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
@targos targos mentioned this pull request Nov 28, 2023
Merged
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: caveat unavailability of import.meta.resolve in custom
1bc1ddd 
PR-URL: nodejs/node#49242
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
doc: caveat unavailability of import.meta.resolve in custom
1df7903 
PR-URL: nodejs/node#49242
Backport-PR-URL: nodejs/node#50669
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GeoffreyBooth GeoffreyBooth GeoffreyBooth approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees

@JakobJingleheimer JakobJingleheimer

Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backported-to-v18.x PRs backported to the v18.x-staging branch. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

import.meta.resolve no longer available in loaders >= v20
5 participants
@JakobJingleheimer @nodejs-github-bot @aduh95 @GeoffreyBooth @targos