Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_runner: expose spec reporter as newable function #49184

Merged
merged 1 commit into from
Aug 17, 2023
Merged

test_runner: expose spec reporter as newable function #49184

merged 1 commit into from
Aug 17, 2023

Conversation

atlowChemi
Copy link
Member

Fixes: #48112
Ref: #48208

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Aug 15, 2023
@atlowChemi atlowChemi force-pushed the spec-reporter-as-function branch 2 times, most recently from 7a2f61e to f217312 Compare August 15, 2023 18:20
@atlowChemi atlowChemi added test_runner Issues and PRs related to the test runner subsystem. and removed test Issues and PRs related to the tests. labels Aug 15, 2023
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/test_runner

@MoLow
Copy link
Member

MoLow commented Aug 15, 2023

@atlowChemi can you amend the commit message changing from expose test_runner as newable function to expose spec reporter as newable function

@atlowChemi
Copy link
Member Author

@atlowChemi can you amend the commit message changing from expose test_runner as newable function to expose spec reporter as newable function

Oh, of course. That was what I meant, oopsy 🙂

@atlowChemi
Copy link
Member Author

@MoLow fixed commit message, care to re-approve latest commit? 🙂

@atlowChemi atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 16, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 16, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/53370/

@MoLow MoLow changed the title test_runner: expose test_runner as newable function test_runner: expose spec reporter as newable function Aug 16, 2023
@MoLow MoLow added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 16, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 17, 2023
@nodejs-github-bot nodejs-github-bot merged commit a5567c2 into nodejs:main Aug 17, 2023
58 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in a5567c2

@atlowChemi atlowChemi deleted the spec-reporter-as-function branch August 17, 2023 18:37
UlisesGascon pushed a commit that referenced this pull request Sep 10, 2023
@atlowChemi @UlisesGascon
test_runner: expose spec reporter as newable function
283f280 
Fixes: #48112
Ref: #48208
PR-URL: #49184
Refs: #48208
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@UlisesGascon UlisesGascon mentioned this pull request Sep 10, 2023
Merged
@aduh95 aduh95 mentioned this pull request Oct 13, 2023
Closed
targos pushed a commit that referenced this pull request Nov 27, 2023
@atlowChemi @targos
test_runner: expose spec reporter as newable function
95cc98e 
Fixes: #48112
Ref: #48208
PR-URL: #49184
Refs: #48208
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
@targos targos mentioned this pull request Nov 28, 2023
Merged
atlowChemi added a commit to atlowChemi/node that referenced this pull request Apr 7, 2024
@atlowChemi
test_runner: expose lcov reporter as newable function
5b33f9d 
Fixes: nodejs#52385
Ref: nodejs#49184
@atlowChemi atlowChemi mentioned this pull request Apr 7, 2024
Merged
atlowChemi added a commit to atlowChemi/node that referenced this pull request Apr 14, 2024
@atlowChemi
test_runner: expose lcov reporter as newable function
8c31349 
This commit exposes the lcov reporter as a newable function, so that it
can be used in the same way as the other reporters.
This will allow passing in the options to the reporter as well.
This breaks the current behavior of the lcov reporter, which exposes an
instance of the reporter.

Fixes: nodejs#52385
Ref: nodejs#49184
nodejs-github-bot pushed a commit that referenced this pull request Apr 15, 2024
@atlowChemi
test_runner: expose lcov reporter as newable function
0db38f0 
This commit exposes the lcov reporter as a newable function, so that it
can be used in the same way as the other reporters.
This will allow passing in the options to the reporter as well.
This breaks the current behavior of the lcov reporter, which exposes an
instance of the reporter.

Fixes: #52385
Ref: #49184
PR-URL: #52403
Refs: #49184
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test_runner: expose spec reporter as newable function
6d13858 
Fixes: nodejs/node#48112
Ref: nodejs/node#48208
PR-URL: nodejs/node#49184
Refs: nodejs/node#48208
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
sercher added a commit to sercher/graaljs that referenced this pull request Apr 25, 2024
@sercher
test_runner: expose spec reporter as newable function
2bc5396 
Fixes: nodejs/node#48112
Ref: nodejs/node#48208
PR-URL: nodejs/node#49184
Refs: nodejs/node#48208
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
aduh95 pushed a commit that referenced this pull request Apr 30, 2024
@atlowChemi @aduh95
test_runner: expose lcov reporter as newable function
df1080e 
This commit exposes the lcov reporter as a newable function, so that it
can be used in the same way as the other reporters.
This will allow passing in the options to the reporter as well.
This breaks the current behavior of the lcov reporter, which exposes an
instance of the reporter.

Fixes: #52385
Ref: #49184
PR-URL: #52403
Refs: #49184
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@benjamingr benjamingr mentioned this pull request May 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@MoLow MoLow MoLow approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Specify that spec reporter is a class and needs to be instantiate for usage with run
4 participants
@atlowChemi @nodejs-github-bot @MoLow @benjamingr