test,buffer: refactor redeclarations #4893
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many variables in the buffer tests are redeclared. Change them so that they are scoped appropriately.
Trott
added
buffer
|
LGTM |
|
CI was rebooted/reconfigured/something. CI again: https://ci.nodejs.org/job/node-test-pull-request/1409/ |
| @@ -50,7 +50,7 @@ assert.deepEqual(arr, [0, 1, 2, 3, 4]); | |||
|
|
|||
| arr = []; | |||
|
|
|||
| for (var b of buffer.entries()) | |||
| for (b of buffer.entries()) | |||
|
LGTM if CI is fine (can't check right now, it only gives me gateway timeouts). |
|
Holy buildbot failures. Jenkins must have been rebooted or something like that. Wow. Let's try again because it seems awfully lovely and stable right now: https://ci.nodejs.org/job/node-test-pull-request/1421/ |
|
CI is all green. \m/ |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 28, 2016
Many variables in the buffer tests are redeclared. Change them so that they are scoped appropriately. PR-URL: nodejs#4893 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 9429685 |
|
@Trott the build group gave jenkins some love potion this morning. Should be good from here on forward since we're soon deploying nightly jobs to keep it lean. |
rvagg
pushed a commit
that referenced
this pull request
Feb 8, 2016
Many variables in the buffer tests are redeclared. Change them so that they are scoped appropriately. PR-URL: #4893 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 17, 2016
Many variables in the buffer tests are redeclared. Change them so that they are scoped appropriately. PR-URL: #4893 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 18, 2016
Many variables in the buffer tests are redeclared. Change them so that they are scoped appropriately. PR-URL: #4893 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 2, 2016
Many variables in the buffer tests are redeclared. Change them so that they are scoped appropriately. PR-URL: #4893 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com>
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
Many variables in the buffer tests are redeclared. Change them so that they are scoped appropriately. PR-URL: nodejs#4893 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many variables in the buffer tests are redeclared. Change them so that
they are scoped appropriately.
This is approximately 1/3 of the issues needed to be corrected to enable eslint
no-redeclarerule. /cc @targos @silverwind