Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: mention Navigator is a partial implementation #48656

Merged
merged 2 commits into from
Jul 5, 2023
Merged

doc: mention Navigator is a partial implementation #48656

merged 2 commits into from
Jul 5, 2023

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Jul 5, 2023

Follow-up for #47769 (comment)

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jul 5, 2023
@MoLow
Copy link
Member Author

MoLow commented Jul 5, 2023

CC @anonrig

@MoLow MoLow added the fast-track PRs that do not need to wait for 48 hours to land. label Jul 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2023

Fast-track has been requested by @MoLow. Please 👍 to approve.

@MoLow MoLow added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jul 5, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 5, 2023
@nodejs-github-bot nodejs-github-bot merged commit 6fda81d into nodejs:main Jul 5, 2023
20 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 6fda81d

@MoLow MoLow deleted the navigator-partial branch July 5, 2023 13:13
@juanarbol
Copy link
Member

juanarbol commented Jul 13, 2023 •
edited
Loading

This depends on a semver-major change, please do not land on v20.x (#47769)

@juanarbol juanarbol added the dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. label Jul 13, 2023
@juanarbol juanarbol mentioned this pull request Jul 13, 2023
Merged
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@MoLow @Ceres6
doc: mention Navigator is a partial implementation
5d13c06 
PR-URL: nodejs#48656
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Ceres6 pushed a commit to Ceres6/node that referenced this pull request Aug 14, 2023
@MoLow @Ceres6
doc: mention Navigator is a partial implementation
862ad22 
PR-URL: nodejs#48656
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@ruyadorno ruyadorno added dont-land-on-v16.x dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. labels Sep 11, 2023
@RafaelGSS RafaelGSS mentioned this pull request Oct 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anonrig anonrig anonrig approved these changes

@legendecas legendecas legendecas approved these changes

Assignees
No one assigned
Labels
commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations. dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MoLow @nodejs-github-bot @juanarbol @anonrig @legendecas @ruyadorno