Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http2: improve nghttp2 error callback #47840

Merged

Commits on May 3, 2023

  1. http2: improve nghttp2 error callback

    The http2 implementation uses the deprecated function
    nghttp2_session_callbacks_set_error_callback, which does not supply an
    error code but only an error message. This so far forced node's error
    callback to rely on the error message in order to distinguish between
    different errors, which is fragile and inefficient.
    
    Use the newer nghttp2_session_callbacks_set_error_callback2 function
    instead, which is not deprecated and which provides the exact error code
    to node's error callback.
    tniessen committed May 3, 2023
    Configuration menu
    Copy the full SHA
    0ec6128 View commit details
    Browse the repository at this point in the history