Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bootstrap: support namespaced builtins in snapshot scripts #47467

Merged
merged 1 commit into from
Apr 11, 2023

Conversation

joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Apr 7, 2023

This enables e.g. require('node:fs') in the snapshot scripts (which is done by our doc example, but didn't actually work without this patch).

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Apr 7, 2023
@nodejs-github-bot
Copy link
Collaborator

@joyeecheung
Copy link
Member Author

cc @nodejs/startup

@joyeecheung joyeecheung added the review wanted PRs that need reviews. label Apr 9, 2023
@joyeecheung
Copy link
Member Author

Can I get another review to unblock #47468? Thanks @nodejs/startup

@legendecas legendecas added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 11, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 11, 2023
@nodejs-github-bot nodejs-github-bot merged commit 77561d0 into nodejs:main Apr 11, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 77561d0

targos pushed a commit that referenced this pull request May 2, 2023
PR-URL: #47467
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@targos targos mentioned this pull request May 2, 2023
danielleadams pushed a commit that referenced this pull request Jul 6, 2023
PR-URL: #47467
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
MoLow pushed a commit to MoLow/node that referenced this pull request Jul 6, 2023
PR-URL: nodejs#47467
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. review wanted PRs that need reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants