Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: make test-cluster-disconnect-leak reliable #4736

Closed
wants to merge 2 commits into from
Closed

test: make test-cluster-disconnect-leak reliable #4736

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fe44bc
test: make test-cluster-disconnect-leak reliable
Trott Jan 18, 2016
5b7cf25
fixup per Santi
Trott Jan 18, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 14 additions & 32 deletions test/sequential/test-cluster-disconnect-leak.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,47 +1,29 @@
'use strict';
// Flags: --expose-internals

// Test fails in Node v5.4.0 and passes in v5.4.1 and newer.

const common = require('../common');
const assert = require('assert');
const net = require('net');
const cluster = require('cluster');
const handles = require('internal/cluster').handles;
const os = require('os');

if (common.isWindows) {
console.log('1..0 # Skipped: This test does not apply to Windows.');
return;
}
const noop = () => {};

cluster.schedulingPolicy = cluster.SCHED_NONE;

if (cluster.isMaster) {
const cpus = os.cpus().length;
const tries = cpus > 8 ? 128 : cpus * 16;

const worker1 = cluster.fork();
worker1.on('message', common.mustCall(() => {
worker1.disconnect();
for (let i = 0; i < tries; ++ i) {
const w = cluster.fork();
w.on('online', common.mustCall(w.disconnect));
}
}));

cluster.on('exit', common.mustCall((worker, code) => {
assert.strictEqual(code, 0, 'worker exited with error');
}, tries + 1));

process.on('exit', () => {
assert.deepEqual(Object.keys(cluster.workers), []);
assert.strictEqual(Object.keys(handles).length, 0);
});
const worker = cluster.fork();

// This is the important part of the test: Confirm that `disconnect` fires.
worker.on('disconnect', common.mustCall(noop));

// These are just some extra stuff we're checking for good measure...
worker.on('exit', common.mustCall(noop));
cluster.on('exit', common.mustCall(noop));

cluster.disconnect();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also check that the exit event is called on the worker and that the cluster.disconnect callback is also called

return;
}

var server = net.createServer();
const server = net.createServer();

server.listen(common.PORT, function() {
process.send('listening');
});
server.listen(common.PORT);