Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src: make AliasedBuffers in the binding data weak #47354

Merged
merged 1 commit into from
Apr 20, 2023
Merged

src: make AliasedBuffers in the binding data weak #47354

merged 1 commit into from
Apr 20, 2023

Commits on Apr 4, 2023

  1. src: make AliasedBuffers in the binding data weak 

    The binding data holds references to the AliasedBuffers directly
from their wrappers which already ensures that the AliasedBuffers
won't be accessed when the wrappers are GC'ed. So we can just
make the global references to the AliasedBuffers weak. This way
we can simply deserialize the typed arrays when deserialize the
binding data and avoid the extra Object::Set() calls. It also
eliminates the caveat in the JS land where aliased buffers must
be dynamically read from the binding.
    @joyeecheung
    joyeecheung committed Apr 4, 2023
    Configuration menu
    Copy the full SHA
    540c37f View commit details
    Browse the repository at this point in the history