Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crypto: return correct bit length in KeyObject's asymmetricKeyDetails #46106

Merged
merged 1 commit into from
Jan 7, 2023

Conversation

panva
Copy link
Member

@panva panva commented Jan 5, 2023

Our KeyObject details incorrectly ceil bit lengths to the nearest multiple of 8.

@panva panva added the crypto Issues and PRs related to the crypto subsystem. label Jan 5, 2023
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jan 5, 2023
@panva panva added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 5, 2023
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 5, 2023
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

@panva panva added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 5, 2023
@panva panva added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 5, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 7, 2023
@nodejs-github-bot nodejs-github-bot merged commit 021f726 into nodejs:main Jan 7, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 021f726

@panva panva deleted the fix-details-bitlenghts branch January 7, 2023 13:20
RafaelGSS pushed a commit to RafaelGSS/node that referenced this pull request Jan 17, 2023
PR-URL: nodejs#46106
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
PR-URL: #46106
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@RafaelGSS RafaelGSS mentioned this pull request Jan 20, 2023
juanarbol pushed a commit that referenced this pull request Jan 26, 2023
PR-URL: #46106
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
juanarbol pushed a commit that referenced this pull request Jan 31, 2023
PR-URL: #46106
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@sigalsMelio
Copy link

I am trying to understand in what version this is fixed, I cannot find it in release notes. We are experiencing this issue in 18.18.2

@panva
Copy link
Member Author

panva commented Nov 21, 2023

I am trying to understand in what version this is fixed, I cannot find it in release notes. We are experiencing this issue in 18.18.2

It was first released in v19.15.0 and backported to v18.x with v18.14.0

@sigalsMelio
Copy link

I am trying to understand in what version this is fixed, I cannot find it in release notes. We are experiencing this issue in 18.18.2

It was first released in v19.15.0 and backported to v18.x with v18.14.0

Thank you @panva , I don't know why it still happens then

@tniessen
Copy link
Member

@sigalsMelio Could you please open a new issue with a description and reproduction if possible?

@sigalsMelio
Copy link

@tniessen trying to figure out whether it's something I need to resolve with jsonwebtoken

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants