Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v16.x backport] tools: refactor avoid-prototype-pollution lint rule #44926

Closed
wants to merge 3 commits into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Oct 8, 2022

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. readline Issues and PRs related to the built-in readline module. tools Issues and PRs related to the tools directory. v16.x labels Oct 8, 2022
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 force-pushed the backport-avoid-prototype-pollution branch from 871d33d to b87d6d3 Compare October 11, 2022 03:45
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 11, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 11, 2022
@nodejs-github-bot
Copy link
Collaborator

@aduh95
Copy link
Contributor Author

aduh95 commented Oct 11, 2022

@juanarbol In case it's not to late / not too much work to integrate this in the 16.18.0 proposal, I think this can land :) (if it's not convenient for you to add it, no worries, it's not urgent at all).

The lint rule was not catching all occurences of unsafe primordials use,
and was too strict on some methods.

PR-URL: #43476
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
PR-URL: #44446
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@aduh95 aduh95 force-pushed the backport-avoid-prototype-pollution branch from b87d6d3 to f8364c5 Compare October 11, 2022 20:16
@aduh95 aduh95 added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 11, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 11, 2022
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

richardlau pushed a commit that referenced this pull request Nov 23, 2022
richardlau pushed a commit that referenced this pull request Nov 23, 2022
The lint rule was not catching all occurences of unsafe primordials use,
and was too strict on some methods.

PR-URL: #43476
Backport-PR-URL: #44926
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
richardlau pushed a commit that referenced this pull request Nov 23, 2022
PR-URL: #44446
Backport-PR-URL: #44926
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
@richardlau
Copy link
Member

Landed in 7c0da6a...cc819b4.

@richardlau richardlau closed this Nov 23, 2022
@richardlau richardlau deleted the backport-avoid-prototype-pollution branch November 23, 2022 17:20
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
The lint rule was not catching all occurences of unsafe primordials use,
and was too strict on some methods.

PR-URL: nodejs/node#43476
Backport-PR-URL: nodejs/node#44926
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
PR-URL: nodejs/node#44446
Backport-PR-URL: nodejs/node#44926
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
The lint rule was not catching all occurences of unsafe primordials use,
and was too strict on some methods.

PR-URL: nodejs/node#43476
Backport-PR-URL: nodejs/node#44926
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
guangwong pushed a commit to noslate-project/node that referenced this pull request Jan 3, 2023
PR-URL: nodejs/node#44446
Backport-PR-URL: nodejs/node#44926
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. net Issues and PRs related to the net subsystem. readline Issues and PRs related to the built-in readline module. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants