test: write to tmp dir rather than fixture dir #4489
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test-fs-realpath.js was writing files to the fixture dir. This changes it to use the temp directory instead. This also replaces some of the string concatenation for paths with uses of path.join() and path.relative().
Trott
added
fs
|
Good catch. CI: https://ci.nodejs.org/job/node-test-commit/1586/ |
|
LGTM. For the record, this test is hell to work with 😞 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jan 2, 2016
test-fs-realpath.js was writing files to the fixture dir. This changes it to use the temp directory instead. This also replaces some of the string concatenation for paths with uses of path.join() and path.relative(). PR-URL: nodejs#4489 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
|
Landed in 4e155e8 |
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Jan 6, 2016
test-fs-realpath.js was writing files to the fixture dir. This changes it to use the temp directory instead. This also replaces some of the string concatenation for paths with uses of path.join() and path.relative(). PR-URL: nodejs#4489 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
|
@Trott this appears to not merge cleanly into v4.x-staging Would you be able to backport this commit and send it as a PR against v4.x-staging? |
|
@thealphanerd This will land cleanly on v4.x-staging if you land #3325 first. |
jasnell
pushed a commit
that referenced
this pull request
Jan 15, 2016
test-fs-realpath.js was writing files to the fixture dir. This changes it to use the temp directory instead. This also replaces some of the string concatenation for paths with uses of path.join() and path.relative(). PR-URL: #4489 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
|
Landed in v4.x-staging in 3fa0d4a |
MylesBorins
pushed a commit
that referenced
this pull request
Jan 19, 2016
test-fs-realpath.js was writing files to the fixture dir. This changes it to use the temp directory instead. This also replaces some of the string concatenation for paths with uses of path.join() and path.relative(). PR-URL: #4489 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Merged
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
test-fs-realpath.js was writing files to the fixture dir. This changes it to use the temp directory instead. This also replaces some of the string concatenation for paths with uses of path.join() and path.relative(). PR-URL: nodejs#4489 Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test-fs-realpath.js was writing files to the fixture dir. This changes
it to use the temp directory instead. This also replaces some of the
string concatenation for paths with uses of path.join() and
path.relative().