Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use async/await in test-debugger-exceptions #44690

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

pete3249
Copy link
Contributor

@pete3249 pete3249 commented Sep 16, 2022

Changes the promises to async/await in test/parallel/test-debugger-exceptions.js.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Sep 16, 2022
@Trott Trott added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 16, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 17, 2022
@nodejs-github-bot
Copy link
Collaborator

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2022
@Trott Trott removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2022
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 23, 2022
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2022
@nodejs-github-bot
Copy link
Collaborator

@Trott Trott added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Sep 28, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 28, 2022
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@Trott
Copy link
Member

Trott commented Sep 29, 2022

Not sure why the test-worker-prof test is failing on Windows over and over on Jenkins, but I'll try rebasing and force pushing to hope it fixes it.

@Trott Trott changed the title src: change promises to async await test: change promises to async await Sep 29, 2022
@Trott Trott changed the title test: change promises to async await test: use async/await in test-debugger-exceptions Sep 29, 2022
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 29, 2022
@nodejs-github-bot
Copy link
Collaborator

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 30, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 30, 2022
@nodejs-github-bot nodejs-github-bot merged commit bf0c312 into nodejs:main Sep 30, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in bf0c312

@Trott
Copy link
Member

Trott commented Sep 30, 2022

Thanks for the contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants