Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: refactor to top-level await #43500

Merged
merged 3 commits into from
Jun 23, 2022
Merged

test: refactor to top-level await #43500

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
069a67e
test: refactor to top-level await
meekdenzo Jun 20, 2022
b6da998
Update test/parallel/test-debugger-address.mjs
meekdenzo Jun 23, 2022
a36b9a2
Update test/parallel/test-debugger-address.mjs
meekdenzo Jun 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 23 additions & 26 deletions test/parallel/test-debugger-address.js → test/parallel/test-debugger-address.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,12 @@
'use strict';
const common = require('../common');
import { skipIfInspectorDisabled } from '../common/index.mjs';

common.skipIfInspectorDisabled();
skipIfInspectorDisabled();

const fixtures = require('../common/fixtures');
const startCLI = require('../common/debugger');
import * as fixtures from '../common/fixtures.mjs';
import startCLI from '../common/debugger.js';

const assert = require('assert');
const { spawn } = require('child_process');
import assert from 'assert';
import { spawn } from 'child_process';

// NOTE(oyyd): We might want to import this regexp from "lib/_inspect.js"?
const kDebuggerMsgReg = /Debugger listening on ws:\/\/\[?(.+?)\]?:(\d+)\//;
Expand Down Expand Up @@ -37,7 +36,7 @@ function launchTarget(...args) {
}

{
const script = fixtures.path('debugger/alive.js');
const script = path('debugger/alive.js');
meekdenzo marked this conversation as resolved.
Show resolved Hide resolved
let cli = null;
let target = null;

Expand All @@ -53,22 +52,20 @@ function launchTarget(...args) {
assert.ifError(error);
}

(async () => {
try {
const { childProc, host, port } = await launchTarget('--inspect=0', script);
target = childProc;
cli = startCLI([`${host || '127.0.0.1'}:${port}`]);
await cli.waitForPrompt();
await cli.command('sb("alive.js", 3)');
await cli.waitFor(/break/);
await cli.waitForPrompt();
assert.match(
cli.output,
/> 3 {3}\+\+x;/,
'marks the 3rd line'
);
} finally {
cleanup();
}
})().then(common.mustCall());
try {
const { childProc, host, port } = await launchTarget('--inspect=0', script);
target = childProc;
cli = startCLI([`${host || '127.0.0.1'}:${port}`]);
await cli.waitForPrompt();
await cli.command('sb("alive.js", 3)');
await cli.waitFor(/break/);
await cli.waitForPrompt();
assert.match(
cli.output,
/> 3 {3}\+\+x;/,
'marks the 3rd line'
);
} finally {
cleanup();
}
}