Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: change FormatSize to actually accept a size_t #43464

Merged

Conversation

tniessen
Copy link
Member

This function is only called with size_t values and it does not deal with unsigned values nicely, so its argument type should be size_t.

This function is only called with size_t values and it does not deal
with unsigned values nicely, so its argument type should be size_t.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jun 18, 2022
@tniessen tniessen added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 18, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 18, 2022
@nodejs-github-bot

This comment was marked as outdated.

@tniessen tniessen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 18, 2022
@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot

This comment was marked as outdated.

@nodejs-github-bot
Copy link
Collaborator

@tniessen tniessen added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 20, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 20, 2022
@nodejs-github-bot nodejs-github-bot merged commit b574532 into nodejs:main Jun 20, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in b574532

F3n67u pushed a commit to F3n67u/node that referenced this pull request Jun 24, 2022
This function is only called with size_t values and it does not deal
with unsigned values nicely, so its argument type should be size_t.

PR-URL: nodejs#43464
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
targos pushed a commit that referenced this pull request Jul 12, 2022
This function is only called with size_t values and it does not deal
with unsigned values nicely, so its argument type should be size_t.

PR-URL: #43464
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants