Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove eslint-disable comments from fixtures #41859

Merged
merged 1 commit into from
Feb 6, 2022
Merged

test: remove eslint-disable comments from fixtures #41859

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion test/fixtures/es-module-loaders/loader-invalid-url.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable node-core/required-modules */
export async function resolve(specifier, { parentURL, importAssertions }, defaultResolve) {
if (parentURL && specifier === '../fixtures/es-modules/test-esm-ok.mjs') {
return {
Expand Down
1 change: 0 additions & 1 deletion test/fixtures/es-module-loaders/throw-undefined.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
'use strict';
/* eslint-disable node-core/required-modules */

throw undefined;
1 change: 0 additions & 1 deletion test/fixtures/es-modules/import-json-named-export.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@
/* eslint-disable no-unused-vars */
import { ofLife } from '../experimental.json' assert { type: 'json' };
1 change: 0 additions & 1 deletion test/fixtures/wpt/streams/readable-streams/general.any.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -630,7 +630,6 @@ promise_test(() => {
let pullCalled = 0;
let cancelCalled = 0;

/* eslint-disable no-use-before-define */
class Source {
start(c) {
startCalled++;
Expand Down
1 change: 0 additions & 1 deletion test/fixtures/wpt/streams/readable-streams/patched-global.any.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@ test(t => {

const trappedProperties = ['highWaterMark', 'size', 'start', 'type', 'mode'];
for (const property of trappedProperties) {
// eslint-disable-next-line no-extend-native, accessor-pairs
Object.defineProperty(Object.prototype, property, {
get() { throw new Error(`${property} getter called`); },
configurable: true
Expand Down
1 change: 0 additions & 1 deletion test/fixtures/wpt/streams/resources/test-utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ self.garbageCollect = () => {
// Present in some WebKit development environments
GCController.collect();
} else {
/* eslint-disable no-console */
console.warn('Tests are running without the ability to do manual garbage collection. They will still work, but ' +
'coverage will be suboptimal.');
/* eslint-enable no-console */
Expand Down
2 changes: 0 additions & 2 deletions test/fixtures/wpt/streams/transform-streams/patched-global.any.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,13 +5,11 @@
// interfering with other tests.

test(t => {
// eslint-disable-next-line no-extend-native, accessor-pairs
Object.defineProperty(Object.prototype, 'highWaterMark', {
set() { throw new Error('highWaterMark setter called'); },
configurable: true
});

// eslint-disable-next-line no-extend-native, accessor-pairs
Object.defineProperty(Object.prototype, 'size', {
set() { throw new Error('size setter called'); },
configurable: true
Expand Down